[GitHub] [spark] grundprinzip commented on a diff in pull request #39214: [SPARK-41707][CONNECT] Implement Catalog API in Spark Connect

[GitBox <gi...@apache.org>]

grundprinzip commented on code in PR #39214:
URL: https://github.com/apache/spark/pull/39214#discussion_r1057439608


##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -68,6 +69,37 @@ message Relation {
     StatCrosstab crosstab = 101;
     StatDescribe describe = 102;
 
+    // Catalog API (internal-only)

Review Comment:
   The better way of dealing with this is to wrap all of the catalog messages into a parent message. This makes it easier to reason about this and eventually remove if we want.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org