You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/09/08 17:54:45 UTC

[jira] [Commented] (STORM-943) In TestHiveBolt make the collector mock slightly more precise

    [ https://issues.apache.org/jira/browse/STORM-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14735033#comment-14735033 ] 

ASF GitHub Bot commented on STORM-943:
--------------------------------------

Github user dossett commented on the pull request:

    https://github.com/apache/storm/pull/583#issuecomment-138607384
  
    @revans2 Per your suggestion I did create a JIRA and associate it.  Feel free to merge this at your convenience.  Thanks!


> In TestHiveBolt make the collector mock slightly more precise
> -------------------------------------------------------------
>
>                 Key: STORM-943
>                 URL: https://issues.apache.org/jira/browse/STORM-943
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: external
>            Reporter: Aaron Dossett
>            Assignee: Aaron Dossett
>            Priority: Trivial
>
> The OutputCollector passed to bolt.prepare() can be mocked directly instead of mocking an IOutputCollector used to construct the collector each time. This makes the tests slightly more readable and it will be easier to verify more complex interactions with the collector in the future if needed.
> Resolved by this PR: https://github.com/apache/storm/pull/583



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)