You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/21 00:41:04 UTC
[GitHub] [incubator-shardingsphere] kimmking opened a new pull request
#4393: sync server.yaml with proxy and distribution
kimmking opened a new pull request #4393: sync server.yaml with proxy and distribution
URL: https://github.com/apache/incubator-shardingsphere/pull/4393
Changes proposed in this pull request:
- sync server.yaml with proxy-bootstrap and proxy-distribution projects
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull
request #4393: sync server.yaml with proxy and distribution
Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #4393: sync server.yaml with proxy and distribution
URL: https://github.com/apache/incubator-shardingsphere/pull/4393#discussion_r382342667
##########
File path: sharding-distribution/sharding-proxy-distribution/src/main/resources/conf/server.yaml
##########
@@ -22,12 +22,17 @@
######################################################################################################
#
#orchestration:
-# name: orchestration_ds
-# overwrite: true
-# registry:
-# type: zookeeper
+# orchestration_ds:
+# orchestrationType: registry_center,config_center,distributed_lock_manager
+# instanceType: zookeeper
# serverLists: localhost:2181
# namespace: orchestration
+# props:
+# overwrite: false
+# retryIntervalMilliseconds: 500
+# timeToLiveSeconds: 60
+# maxRetries: 3
+# operationTimeoutMilliseconds: 500
Review comment:
There are one more space per line? For yaml file format, It maybe cause error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull
request #4393: sync server.yaml with proxy and distribution
Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #4393: sync server.yaml with proxy and distribution
URL: https://github.com/apache/incubator-shardingsphere/pull/4393#discussion_r382342667
##########
File path: sharding-distribution/sharding-proxy-distribution/src/main/resources/conf/server.yaml
##########
@@ -22,12 +22,17 @@
######################################################################################################
#
#orchestration:
-# name: orchestration_ds
-# overwrite: true
-# registry:
-# type: zookeeper
+# orchestration_ds:
+# orchestrationType: registry_center,config_center,distributed_lock_manager
+# instanceType: zookeeper
# serverLists: localhost:2181
# namespace: orchestration
+# props:
+# overwrite: false
+# retryIntervalMilliseconds: 500
+# timeToLiveSeconds: 60
+# maxRetries: 3
+# operationTimeoutMilliseconds: 500
Review comment:
There are one more space per line? For yaml file format, It maybe cause error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull
request #4393: sync server.yaml with proxy and distribution
Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #4393: sync server.yaml with proxy and distribution
URL: https://github.com/apache/incubator-shardingsphere/pull/4393#discussion_r382343571
##########
File path: sharding-proxy/sharding-proxy-bootstrap/src/main/resources/conf/server.yaml
##########
@@ -55,4 +55,9 @@
# proxy.hint.enabled: false
# query.with.cipher.column: true
# sql.show: false
-# allow.range.query.with.inline.sharding: false
+# allow.range.query.with.inline.sharding: false# proxy.transaction.type: LOCAL
+## proxy.opentracing.enabled: false
+## proxy.hint.enabled: false
+## query.with.cipher.column: true
+## sql.show: false
+## allow.range.query.with.inline.sharding: false
Review comment:
why add these configurations?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao merged pull request #4393:
sync server.yaml with proxy and distribution
Posted by GitBox <gi...@apache.org>.
cherrylzhao merged pull request #4393: sync server.yaml with proxy and distribution
URL: https://github.com/apache/incubator-shardingsphere/pull/4393
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4393: sync
server.yaml with proxy and distribution
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4393: sync server.yaml with proxy and distribution
URL: https://github.com/apache/incubator-shardingsphere/pull/4393#issuecomment-589451532
## Pull Request Test Coverage Report for [Build 1823](https://coveralls.io/builds/28868724)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **2** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.005%**) to **56.469%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28868724/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L72) | 2 | 80.0% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/28868724) |
| :-- | --: |
| Change from base [Build 9679](https://coveralls.io/builds/28867839): | 0.005% |
| Covered Lines: | 11030 |
| Relevant Lines: | 19533 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull
request #4393: sync server.yaml with proxy and distribution
Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4393: sync server.yaml with proxy and distribution
URL: https://github.com/apache/incubator-shardingsphere/pull/4393#discussion_r382344980
##########
File path: sharding-proxy/sharding-proxy-bootstrap/src/main/resources/conf/server.yaml
##########
@@ -55,4 +55,9 @@
# proxy.hint.enabled: false
# query.with.cipher.column: true
# sql.show: false
-# allow.range.query.with.inline.sharding: false
+# allow.range.query.with.inline.sharding: false# proxy.transaction.type: LOCAL
+## proxy.opentracing.enabled: false
+## proxy.hint.enabled: false
+## query.with.cipher.column: true
+## sql.show: false
+## allow.range.query.with.inline.sharding: false
Review comment:
these already canceled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4393: sync server.yaml with proxy and distribution
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4393: sync server.yaml with proxy and distribution
URL: https://github.com/apache/incubator-shardingsphere/pull/4393#issuecomment-589451532
## Pull Request Test Coverage Report for [Build 1824](https://coveralls.io/builds/28868759)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **2** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.01%**) to **56.474%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28868759/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L72) | 2 | 80.0% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/28868759) |
| :-- | --: |
| Change from base [Build 9679](https://coveralls.io/builds/28867839): | 0.01% |
| Covered Lines: | 11031 |
| Relevant Lines: | 19533 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services