You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/08/27 09:58:12 UTC
[GitHub] [geode-native] albertogpz commented on a change in pull request #642: GEODE-8457: Fix crash when IO_error and single-hop=false
albertogpz commented on a change in pull request #642:
URL: https://github.com/apache/geode-native/pull/642#discussion_r478300118
##########
File path: cppcache/src/ThinClientPoolDM.cpp
##########
@@ -1428,10 +1428,12 @@ GfErrType ThinClientPoolDM::sendSyncRequest(
}
excludeServers.insert(ServerLocation(ep->name()));
if (error == GF_IOERR) {
- auto sl = std::make_shared<BucketServerLocation>(ep->name());
- LOGINFO("Removing bucketServerLocation %s due to GF_IOERR",
- sl->toString().c_str());
- m_clientMetadataService->removeBucketServerLocation(sl);
+ if (m_clientMetadataService != nullptr) {
Review comment:
The m_clientMetadataService member variable is null when single-hop is not enabled.
I have duplicated the test cases I created to verify the fix for GEODE-8231 which had single-hop enabled, to also test the case when single-hop is disabled.
##########
File path: cppcache/src/ThinClientPoolDM.cpp
##########
@@ -1428,10 +1428,12 @@ GfErrType ThinClientPoolDM::sendSyncRequest(
}
excludeServers.insert(ServerLocation(ep->name()));
if (error == GF_IOERR) {
- auto sl = std::make_shared<BucketServerLocation>(ep->name());
- LOGINFO("Removing bucketServerLocation %s due to GF_IOERR",
- sl->toString().c_str());
- m_clientMetadataService->removeBucketServerLocation(sl);
+ if (m_clientMetadataService != nullptr) {
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org