[GitHub] chetanmeh commented on issue #3771: Disable inlining logic if maxInlineSize is zero

[GitBox <gi...@apache.org>]

chetanmeh commented on issue #3771: Disable inlining logic if maxInlineSize is zero
URL: https://github.com/apache/incubator-openwhisk/pull/3771#issuecomment-397664025
 
 
   Below are the steps to test that action update work with old format name
   
   ```bash
   #Set the action name
   $ export ACTION_NAME="javatest2"
   
   #Creates an action where attachment name is of old format `jarfile`
   $ cat > action.json << EOL
   {
       "name": "$ACTION_NAME",
       "_id": "guest/$ACTION_NAME",
       "publish": false,
       "annotations": [{
           "key": "exec",
           "value": "java"
       }],
       "version": "0.0.1",
       "updated": 1529072490140,
       "entityType": "action",
       "exec": {
           "kind": "java",
           "code": {
               "attachmentName": "jarfile",
               "attachmentType": "application/java-archive"
           },
           "binary": true,
           "main": "Hello"
       },
       "parameters": [],
       "limits": {
           "timeout": 60000,
           "memory": 256,
           "logs": 10
       },
       "namespace": "guest"
   }
   EOL
   $ curl -H 'Host: localhost:5984' -H 'Authorization: Basic d2hpc2tfYWRtaW46c29tZV9wYXNzdzByZA==' -H 'Accept: application/json' -H 'User-Agent: akka-http/10.1.1' -H 'Content-Type: application/json' --data-binary '@action.json' -X PUT 'http://localhost:5984/whisk_local_whisks/guest%2F$ACTION_NAME'
   
   #output
   {"ok":true,"id":"guest/$ACTION_NAME","rev":"1-095885037436f519d24bbf3c1db91154"}
   
   #Generate any large file named as jar. We are not going to invoke it. Just do CRUD
   $mkfile -n 2m "$ACTION_NAME.jar"
   
   #Use the rev from last command
   $curl -H 'Host: localhost:5984' -H 'Authorization: Basic d2hpc2tfYWRtaW46c29tZV9wYXNzdzByZA==' -H 'Accept: application/json' -H 'If-Match: "1-095885037436f519d24bbf3c1db91154"' -H 'User-Agent: akka-http/10.1.1' -H 'Content-Type: application/java-archive' --data-binary '@$ACTION_NAME.jar' -X PUT 'http://localhost:5984/whisk_local_whisks/guest%2F$ACTION_NAME/jarfile'
   
   $ wsk -i action list
   actions
   /guest/javatest1                                                       private java
   /guest/javatest2                                                       private java
   
   $ mkfile -n 3m "updated.jar"
   
   $ wsk -i action update javatest2 updated.jar --main Hello
   ok: updated action javatest2
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services