You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "tahvane1 (via GitHub)" <gi...@apache.org> on 2024/12/09 13:34:00 UTC

[PR] improve pdf export quality [superset]

tahvane1 opened a new pull request, #31349:
URL: https://github.com/apache/superset/pull/31349

   This PR uses img2pdf to export charts to pdf. Current solutions uses compression in such way that pdf is grainy.
   Using img2pdf removes this issue mostly.
   
   ### SUMMARY
   Current pdf quality is poor and this improves it significantly
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   
   ### TESTING INSTRUCTIONS
   img2pdf needs to be added to docker images.
   
   ### ADDITIONAL INFORMATION
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] feat: improve pdf export quality [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #31349:
URL: https://github.com/apache/superset/pull/31349#issuecomment-2529066400

   Do we know if the low resolution is caused by the capture method (`Image.open(BytesIO(snap))`) or by the output method (`images[0].save(...)`)? Apparently if it's the latter, you can add a `resolution=300.0` parameter.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] feat: improve pdf export quality [superset]

Posted by "tahvane1 (via GitHub)" <gi...@apache.org>.
tahvane1 commented on PR #31349:
URL: https://github.com/apache/superset/pull/31349#issuecomment-2528857345

   img2pdf is using GNU Lesser General Public License v3 and it seems that it is not accepted in ASF projects. So need to look for alternative approach then.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] feat: improve pdf export quality [superset]

Posted by "tahvane1 (via GitHub)" <gi...@apache.org>.
tahvane1 closed pull request #31349: feat: improve pdf export quality
URL: https://github.com/apache/superset/pull/31349


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] feat: improve pdf export quality [superset]

Posted by "tahvane1 (via GitHub)" <gi...@apache.org>.
tahvane1 commented on PR #31349:
URL: https://github.com/apache/superset/pull/31349#issuecomment-2529547031

   Resolution does not fix issue. I can get similar quality by setting quality=100 but this results to a pdf that has double the size what img2pdf produces. I will continue my testings...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] feat: improve pdf export quality [superset]

Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #31349:
URL: https://github.com/apache/superset/pull/31349#issuecomment-2529025643

   > img2pdf is using GNU Lesser General Public License v3 and it seems that it is not accepted in ASF projects. So need to look for alternative approach then.
   
   Dang, that's a real shame! 🙁 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] feat: improve pdf export quality [superset]

Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #31349:
URL: https://github.com/apache/superset/pull/31349#issuecomment-2536705283

   FYI I converted this to draft. @tahvane1 please feel free to change it back to non-draft if you find a new ASF-compliant way to fix this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org