You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2017/11/13 05:37:42 UTC

[GitHub] mistercrunch commented on a change in pull request #3850: [sql lab] minor cosmetic touchups on Run / Save buttons

mistercrunch commented on a change in pull request #3850: [sql lab] minor cosmetic touchups on Run / Save buttons
URL: https://github.com/apache/incubator-superset/pull/3850#discussion_r150451400
 
 

 ##########
 File path: superset/assets/stylesheets/superset.less
 ##########
 @@ -32,10 +32,6 @@ input.form-control {
     background-color: white;
 }
 
-input.form-control.input-sm {
 
 Review comment:
   @graceguo-supercat this redefines the theme's input-sm from 30 to 36 which isn't ideal. Yet reverting this doesn't seem to affect react-select in a bad way... Do you more insight as to why this css entry is here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services