You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "benmccrea (via GitHub)" <gi...@apache.org> on 2023/10/13 20:27:36 UTC

[PR] kernel/os: Fix issue that causes WDOG reset reason to be lost [mynewt-core]

benmccrea opened a new pull request, #3094:
URL: https://github.com/apache/mynewt-core/pull/3094

   In the default irq handler, hal_watchdog_tickle() was called before doing a core dump but on Dialog da1469x this causes the reset reason to be lost, and reboot log was recording the reset reason as HAL_RESET_SOFT instead of HAL_RESET_WDOG.
   
   The issue is fixed by calling hal_watchdog_disable() instead of hal_watchdog_tickle() before doing a core dump.
   
   This PR also adds hal_watchdog_disable() to the HAL API for all MCUs (for now it is implemented only for Dialog da1469x and CMAC).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] kernel/os: Fix issue that causes WDOG reset reason to be lost [mynewt-core]

Posted by "benmccrea (via GitHub)" <gi...@apache.org>.
benmccrea commented on PR #3094:
URL: https://github.com/apache/mynewt-core/pull/3094#issuecomment-1765387712

   @andrzej-kaczmarek Thanks, I agree with you. We'll find a different way. We can use os_coredump_cb as you suggest, or we might be able to modify how watchdog reboot reason is detected for da1469x so that it isn't lost by the tickle. 
   Closing this unmerged. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] kernel/os: Fix issue that causes WDOG reset reason to be lost [mynewt-core]

Posted by "benmccrea (via GitHub)" <gi...@apache.org>.
benmccrea closed pull request #3094: kernel/os: Fix issue that causes WDOG reset reason to be lost
URL: https://github.com/apache/mynewt-core/pull/3094


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] kernel/os: Fix issue that causes WDOG reset reason to be lost [mynewt-core]

Posted by "andrzej-kaczmarek (via GitHub)" <gi...@apache.org>.
andrzej-kaczmarek commented on PR #3094:
URL: https://github.com/apache/mynewt-core/pull/3094#issuecomment-1764063852

   If you replace `tickle` with `disable` and leave `disable` not implemented for all platforms but dialog, it will possibly break those platforms as in mentioned issue. Also watchdog cannot be disabled on some platforms, in particular nrf52, so this won't work.
   
   So perhaps what can be done instead is to make call to `tickle` optional via syscfg and then use coredump callback to disable watchdog via registers to avoid having an API that is not implemented on any platform.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org