You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2023/01/16 12:18:49 UTC
[GitHub] [dubbo] aamingaa commented on a diff in pull request #11309: Add xdsroute observe logic
aamingaa commented on code in PR #11309:
URL: https://github.com/apache/dubbo/pull/11309#discussion_r1071177823
##########
dubbo-xds/src/main/java/org/apache/dubbo/rpc/cluster/router/xds/XdsRouter.java:
##########
@@ -28,19 +28,9 @@
import org.apache.dubbo.rpc.cluster.router.RouterSnapshotNode;
import org.apache.dubbo.rpc.cluster.router.state.AbstractStateRouter;
import org.apache.dubbo.rpc.cluster.router.state.BitList;
-import org.apache.dubbo.rpc.cluster.router.xds.rule.ClusterWeight;
-import org.apache.dubbo.rpc.cluster.router.xds.rule.DestinationSubset;
-import org.apache.dubbo.rpc.cluster.router.xds.rule.HTTPRouteDestination;
-import org.apache.dubbo.rpc.cluster.router.xds.rule.HeaderMatcher;
-import org.apache.dubbo.rpc.cluster.router.xds.rule.HttpRequestMatch;
-import org.apache.dubbo.rpc.cluster.router.xds.rule.PathMatcher;
-import org.apache.dubbo.rpc.cluster.router.xds.rule.XdsRouteRule;
-
-import java.util.ArrayList;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Optional;
-import java.util.Set;
+import org.apache.dubbo.rpc.cluster.router.xds.rule.*;
+
+import java.util.*;
Review Comment:
dont use import *
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org