You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by "spmallette (GitHub)" <gi...@apache.org> on 2020/03/31 17:19:00 UTC

[GitHub] [tinkerpop] spmallette opened pull request #1272: TINKERPOP-2345 Improved error message for bad value for math()

https://issues.apache.org/jira/browse/TINKERPOP-2345

This problem really only applies to 3.4.x since by() didn't modulate Map traversers in 3.3.x. This change does also however fix the error message for non-Number objects trying to be passed into a math() expression, but the error is at least more understandable than the NullPointerException - on 3.3.x we get "java.lang.String cannot be cast to java.lang.Number" which while not perfect is probably good enough for that older version. It didn't seem like a big enough problem to add the enhancement there.

All tests pass with `docker/build.sh -t -n -i`

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1272 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette closed pull request #1272: TINKERPOP-2345 Improved error message for bad value for math()

Posted by "spmallette (GitHub)" <gi...@apache.org>.

[ pull request closed by spmallette ]

[ Full content available at: https://github.com/apache/tinkerpop/pull/1272 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org