You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/14 02:38:40 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31823: [SPARK-34630]Added typehint for pyspark.sql.Column.contains

HyukjinKwon commented on a change in pull request #31823:
URL: https://github.com/apache/spark/pull/31823#discussion_r593830911



##########
File path: python/pyspark/sql/column.pyi
##########
@@ -115,3 +115,4 @@ class Column:
     def over(self, window: WindowSpec) -> Column: ...
     def __nonzero__(self) -> None: ...
     def __bool__(self) -> None: ...
+    def contains(self, item: Union[str, Column]) -> Column: ...

Review comment:
       Can we also add the type hint for `__version__`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org