You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/07/04 08:01:49 UTC
[GitHub] [skywalking-python] kezhenxu94 opened a new pull request, #217: Update UI repository link in PR template
kezhenxu94 opened a new pull request, #217:
URL: https://github.com/apache/skywalking-python/pull/217
<!-- Uncomment the following checklist WHEN AND ONLY WHEN you're adding a new plugin -->
<!--
- [ ] Add a test case for the new plugin
- [ ] Add a CHANGELOG entry for the new plugin
- [ ] Add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L415)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
- [ ] Rebuild the `requirements.txt` by running `tools/env/build_requirements_(linux|windows).sh`
- [ ] Rebuild the `Plugins.md` documentation by running `make doc-gen`
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng merged pull request #217: Update UI repository link in PR template
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #217:
URL: https://github.com/apache/skywalking-python/pull/217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] jiang1997 commented on a diff in pull request #217: Update UI repository link in PR template
Posted by GitBox <gi...@apache.org>.
jiang1997 commented on code in PR #217:
URL: https://github.com/apache/skywalking-python/pull/217#discussion_r912745568
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -3,7 +3,7 @@
- [ ] Add a test case for the new plugin
- [ ] Add a CHANGELOG entry for the new plugin
- [ ] Add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L415)
Review Comment:
This link seems 404 now.
Maybe it should be changed to ``https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org