You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by jv...@apache.org on 2014/01/06 18:16:51 UTC
git commit: Updated the notes about the order of processing and a
small problem with the conflation of duplicate checkingin getProjectMap
Updated Branches:
refs/heads/master 7c3052dde -> 6e3f24bab
Updated the notes about the order of processing and a small problem with the conflation of duplicate checkingin getProjectMap
Project: http://git-wip-us.apache.org/repos/asf/maven/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/6e3f24ba
Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/6e3f24ba
Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/6e3f24ba
Branch: refs/heads/master
Commit: 6e3f24babc6290d9370a79a25c748e50ef7d8840
Parents: 7c3052d
Author: Jason van Zyl <ja...@tesla.io>
Authored: Mon Jan 6 12:16:06 2014 -0500
Committer: Jason van Zyl <ja...@tesla.io>
Committed: Mon Jan 6 12:16:06 2014 -0500
----------------------------------------------------------------------
maven-core/src/main/java/org/apache/maven/DefaultMaven.java | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/maven/blob/6e3f24ba/maven-core/src/main/java/org/apache/maven/DefaultMaven.java
----------------------------------------------------------------------
diff --git a/maven-core/src/main/java/org/apache/maven/DefaultMaven.java b/maven-core/src/main/java/org/apache/maven/DefaultMaven.java
index 152bd4b..3fd3ef4 100644
--- a/maven-core/src/main/java/org/apache/maven/DefaultMaven.java
+++ b/maven-core/src/main/java/org/apache/maven/DefaultMaven.java
@@ -183,12 +183,14 @@ public class DefaultMaven
//
// 5) Execute AbstractLifecycleParticipant.afterSessionStart(session)
//
- // 6) Get reactor projects looking for read errors, and duplicate declarations
+ // 6) Get reactor projects looking for general POM errors
//
// 7) Create ProjectDependencyGraph using trimming which takes into account --projects and reactor mode. This ensures
// that the projects passed into the ReactorReader are only those specified.
//
- // 8) Create ReactorReader with the project map created in 7)
+ // 8) Create ReactorReader with the getProjectMap( projects ). NOTE that getProjectMap(projects) is the code that
+ // checks for duplicate projects definitions in the build. Ideally this type of duplicate checking should be part of
+ // getting the reactor projects in 6). The duplicate checking is conflated with getProjectMap(projects).
//
// 9) Execute AbstractLifecycleParticipant.afterProjectsRead(session)
//