You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2023/01/12 22:35:35 UTC
[GitHub] [superset] lilykuang opened a new pull request, #22708: chore: upgrade react to 17.0.2 [WIP]
lilykuang opened a new pull request, #22708:
URL: https://github.com/apache/superset/pull/22708
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: upgrade react to 17.0.2 [superset]
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #22708:
URL: https://github.com/apache/superset/pull/22708#issuecomment-1905766537
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #22708: chore: upgrade react to 17.0.2 [WIP]
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #22708:
URL: https://github.com/apache/superset/pull/22708#issuecomment-1411232334
They don't update the lib during 2 years. I've started rewriting FilterableTable in order to use our new AntD table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: upgrade react to 17.0.2 [WIP] [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #22708:
URL: https://github.com/apache/superset/pull/22708#issuecomment-1867575000
It would be great if we could merge this PR as part of the [4.0 initiative](https://github.com/orgs/apache/projects/292), during the breaking window. During that period, we'll merge many PRs that introduce breaking changes and will need to do a full test of the application, which would be a great opportunity to test the impact of this PR.
If you agree, just add a card to the 4.0 project board about upgrading React to 17 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: upgrade react to 17.0.2 [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #22708:
URL: https://github.com/apache/superset/pull/22708#issuecomment-1868162575
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/22708?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `4 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`5e85f5c`)](https://app.codecov.io/gh/apache/superset/commit/5e85f5c81f66b2da6fa11d9112216004f35170c8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.18% compared to head [(`ae78073`)](https://app.codecov.io/gh/apache/superset/pull/22708?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.18%.
> Report is 4 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/superset/pull/22708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...dashboard/components/SliceHeaderControls/index.tsx](https://app.codecov.io/gh/apache/superset/pull/22708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMvaW5kZXgudHN4) | 50.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/superset/pull/22708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset-frontend/src/pages/Dashboard/index.tsx](https://app.codecov.io/gh/apache/superset/pull/22708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0Rhc2hib2FyZC9pbmRleC50c3g=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/22708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...erset-frontend/src/pages/DatasetCreation/index.tsx](https://app.codecov.io/gh/apache/superset/pull/22708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0RhdGFzZXRDcmVhdGlvbi9pbmRleC50c3g=) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/superset/pull/22708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #22708 +/- ##
==========================================
- Coverage 69.18% 69.18% -0.01%
==========================================
Files 1945 1945
Lines 75971 75984 +13
Branches 8467 8475 +8
==========================================
+ Hits 52559 52566 +7
- Misses 21225 21228 +3
- Partials 2187 2190 +3
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/22708/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/22708/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.51% <42.85%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/22708?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: upgrade react to 17.0.2 [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #22708:
URL: https://github.com/apache/superset/pull/22708#issuecomment-1876966533
> @michael-s-molina @lilykuang Do we know for sure if there are any breaking changes for this PR or are we thinking of putting it into 4.0 just to be extra cautious?
We added the v4.0 label to merge it during the breaking window and reuse the tests/stabilization period given that this impacts the whole application and will require a full test. Is just to be extra cautious and optimize efforts 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lilykuang commented on pull request #22708: chore: upgrade react to 17.0.2 [WIP]
Posted by "lilykuang (via GitHub)" <gi...@apache.org>.
lilykuang commented on PR #22708:
URL: https://github.com/apache/superset/pull/22708#issuecomment-1411233954
sounds good. thank you for the heads up @EugeneTorap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: upgrade react to 17.0.2 [WIP] [superset]
Posted by "lilykuang (via GitHub)" <gi...@apache.org>.
lilykuang commented on PR #22708:
URL: https://github.com/apache/superset/pull/22708#issuecomment-1868142582
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: upgrade react to 17.0.2 [superset]
Posted by "amadejzv (via GitHub)" <gi...@apache.org>.
amadejzv commented on PR #22708:
URL: https://github.com/apache/superset/pull/22708#issuecomment-2100608773
hey @michael-s-molina @kgabryje, any news in this area?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #22708: chore: upgrade react to 17.0.2 [WIP]
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #22708:
URL: https://github.com/apache/superset/pull/22708#issuecomment-1411001902
Hi @lilykuang! I see you removed `react-virtualized` from `package.json`.
Should we rewrite existed code which uses this lib?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: upgrade react to 17.0.2 [WIP] [superset]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #22708:
URL: https://github.com/apache/superset/pull/22708#issuecomment-1866633091
@lilykuang I see there's apparently only two failing tests left here. As this upgrade is very critical for dependency management, I propose just disabling those two tests for now if we can ensure the underlying components are working with the new version. Thoughts @michael-s-molina @kgabryje @eschutho ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: upgrade react to 17.0.2 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #22708:
URL: https://github.com/apache/superset/pull/22708#discussion_r1462465567
##########
superset-frontend/plugins/legacy-plugin-chart-histogram/package.json:
##########
@@ -39,6 +39,6 @@
"peerDependencies": {
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*",
- "react": "^15 || ^16"
+ "react": "^15 || ^16 || ^17"
Review Comment:
Maybe we should drop 15?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: upgrade react to 17.0.2 [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22708:
URL: https://github.com/apache/superset/pull/22708#issuecomment-1905773231
@kgabryje Ephemeral environment spinning up at http://34.221.110.31:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: upgrade react to 17.0.2 [superset]
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on code in PR #22708:
URL: https://github.com/apache/superset/pull/22708#discussion_r1462826127
##########
superset-frontend/plugins/legacy-plugin-chart-histogram/package.json:
##########
@@ -39,6 +39,6 @@
"peerDependencies": {
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*",
- "react": "^15 || ^16"
+ "react": "^15 || ^16 || ^17"
Review Comment:
💯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: upgrade react to 17.0.2 [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #22708:
URL: https://github.com/apache/superset/pull/22708#issuecomment-1922358531
Wondering if we should re-open this against the main fork so more people can collab on it. I don't mind doing the rebasing and re-opening if people are going to push on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: upgrade react to 17.0.2 [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #22708:
URL: https://github.com/apache/superset/pull/22708#issuecomment-1922540614
Any hacks to support conflicting reacts? Plugins-in-iframe-mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lilykuang commented on pull request #22708: chore: upgrade react to 17.0.2 [WIP]
Posted by "lilykuang (via GitHub)" <gi...@apache.org>.
lilykuang commented on PR #22708:
URL: https://github.com/apache/superset/pull/22708#issuecomment-1411204768
@EugeneTorap I removed react-virtualized for testing purpose. I am actually waiting to see if react-virtualized will release a new version since the support for v17 and v18 https://github.com/bvaughn/react-virtualized/pull/1740 is merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: upgrade react to 17.0.2 [superset]
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #22708:
URL: https://github.com/apache/superset/pull/22708#issuecomment-1876075541
@michael-s-molina @lilykuang Do we know for sure if there are any breaking changes for this PR or are we thinking of putting it into 4.0 just to be extra cautious?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: upgrade react to 17.0.2 [WIP] [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22708:
URL: https://github.com/apache/superset/pull/22708#issuecomment-1868143352
@lilykuang Ephemeral environment spinning up at http://54.191.98.204:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: upgrade react to 17.0.2 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #22708:
URL: https://github.com/apache/superset/pull/22708#discussion_r1462466589
##########
superset-frontend/plugins/legacy-plugin-chart-map-box/package.json:
##########
@@ -35,7 +35,7 @@
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*",
"mapbox-gl": "*",
- "react": "^15 || ^16"
+ "react": "^15 || ^16 || ^17"
Review Comment:
... same with the rest of these. We've been on React 16 long enough that I would hope we can drop 15 as a peer dependency? ¯\\\_(ツ)_/¯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: upgrade react to 17.0.2 [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #22708:
URL: https://github.com/apache/superset/pull/22708#issuecomment-1922363292
> Wondering if we should re-open this against the main fork so more people can collab on it. I don't mind doing the rebasing and re-opening if people are going to push on this.
@mistercrunch This was [punted to 5.0](https://github.com/orgs/apache/projects/292?pane=issue&itemId=48329975) because of the following:
> Histogram and Event flow charts use old, unsupported library @data-ui, which is not compatible with React 17. Since there are no easy replacements, we need to rewrite those plugins using a different library or deprecate them before moving on with React 17 upgrade.
So I think we need to resolve some prerequisites before continuing the work. @kgabryje will know more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org