You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "amorynan (via GitHub)" <gi...@apache.org> on 2023/11/15 07:12:24 UTC
[PR] [FIX](map)fix map element_at with decimal value [doris]
amorynan opened a new pull request, #27030:
URL: https://github.com/apache/doris/pull/27030
## Proposed changes
map functions in old planner is defined in py file, which we use template type with origin type. so do not get actually type for match functions
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](map)fix map element_at with decimal value [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on code in PR #27030:
URL: https://github.com/apache/doris/pull/27030#discussion_r1393776046
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java:
##########
@@ -2559,7 +2559,7 @@ protected Type[] getActualArgTypes(Type[] originType) {
}
private MapType getActualMapType(MapType originMapType) {
- return new MapType(getActualType(originMapType.getKeyType()), getActualType(originMapType.getValueType()));
+ return new MapType(originMapType.getKeyType(), originMapType.getValueType());
Review Comment:
struct has not, just return origin type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](map)fix map element_at with decimal value [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27030:
URL: https://github.com/apache/doris/pull/27030#issuecomment-1812070210
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.18 seconds
stream load tsv: 549 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.6 seconds inserted 10000000 Rows, about 349K ops/s
storage size: 17096084666 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](map)fix map element_at with decimal value [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27030:
URL: https://github.com/apache/doris/pull/27030#issuecomment-1813734275
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.7 seconds
stream load tsv: 577 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.2 seconds inserted 10000000 Rows, about 354K ops/s
storage size: 17099349508 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](map)fix map element_at with decimal value [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on code in PR #27030:
URL: https://github.com/apache/doris/pull/27030#discussion_r1393767982
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java:
##########
@@ -2559,7 +2559,7 @@ protected Type[] getActualArgTypes(Type[] originType) {
}
private MapType getActualMapType(MapType originMapType) {
- return new MapType(getActualType(originMapType.getKeyType()), getActualType(originMapType.getValueType()));
+ return new MapType(originMapType.getKeyType(), originMapType.getValueType());
Review Comment:
maybe not, array some functions not has template type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](map)fix map element_at with decimal value [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27030:
URL: https://github.com/apache/doris/pull/27030#issuecomment-1812102496
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit b490ed1d19558d35f3b0578da902f5740d8a8add, data reload: false
run tpch-sf100 query with default conf and session variables
q1 5302 5174 5249 5174
q2 383 163 168 163
q3 2025 1912 1900 1900
q4 1384 1262 1255 1255
q5 3983 3991 4000 3991
q6 250 132 135 132
q7 1421 872 881 872
q8 2748 2784 2754 2754
q9 9941 9865 9617 9617
q10 3443 3512 3540 3512
q11 390 259 260 259
q12 441 279 285 279
q13 4580 3817 3862 3817
q14 307 297 282 282
q15 631 585 568 568
q16 678 588 587 587
q17 1127 961 939 939
q18 7748 7345 7450 7345
q19 1674 1699 1685 1685
q20 578 331 286 286
q21 4424 4027 4065 4027
q22 523 395 408 395
Total cold run time: 53981 ms
Total hot run time: 49839 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 5002 5029 5060 5029
q2 326 217 225 217
q3 4091 3908 4009 3908
q4 2797 2764 2765 2764
q5 9556 9496 9509 9496
q6 250 125 124 124
q7 2680 2273 2299 2273
q8 4848 4827 4889 4827
q9 13227 13095 13072 13072
q10 4079 4164 4177 4164
q11 722 628 650 628
q12 1001 860 838 838
q13 4324 3575 3596 3575
q14 384 348 358 348
q15 617 567 536 536
q16 741 688 691 688
q17 3901 3893 3883 3883
q18 9450 9022 8915 8915
q19 1903 1764 1772 1764
q20 2435 2074 2047 2047
q21 8829 8679 8523 8523
q22 952 851 845 845
Total cold run time: 82115 ms
Total hot run time: 78464 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](map)fix map element_at with decimal value [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #27030:
URL: https://github.com/apache/doris/pull/27030#discussion_r1393766966
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java:
##########
@@ -2559,7 +2559,7 @@ protected Type[] getActualArgTypes(Type[] originType) {
}
private MapType getActualMapType(MapType originMapType) {
- return new MapType(getActualType(originMapType.getKeyType()), getActualType(originMapType.getValueType()));
+ return new MapType(originMapType.getKeyType(), originMapType.getValueType());
Review Comment:
do array and struct have same problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](map)fix map element_at with decimal value [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27030:
URL: https://github.com/apache/doris/pull/27030#issuecomment-1811921205
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/6874090990") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' found no issues.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- build.sh.orig
+++ build.sh
@@ -483,7 +483,7 @@
# Clean and build Backend
if [[ "${BUILD_BE}" -eq 1 ]]; then
update_submodule "be/src/apache-orc" "apache-orc" "https://github.com/apache/doris-thirdparty/archive/refs/heads/orc.tar.gz"
-# update_submodule "be/src/clucene" "clucene" "https://github.com/apache/doris-thirdparty/archive/refs/heads/clucene.tar.gz"
+ # update_submodule "be/src/clucene" "clucene" "https://github.com/apache/doris-thirdparty/archive/refs/heads/clucene.tar.gz"
if [[ -e "${DORIS_HOME}/gensrc/build/gen_cpp/version.h" ]]; then
rm -f "${DORIS_HOME}/gensrc/build/gen_cpp/version.h"
fi
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](map)fix map element_at with decimal value [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #27030:
URL: https://github.com/apache/doris/pull/27030#issuecomment-1811934048
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](map)fix map element_at with decimal value [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #27030:
URL: https://github.com/apache/doris/pull/27030#issuecomment-1811921867
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](map)fix map element_at with decimal value [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27030:
URL: https://github.com/apache/doris/pull/27030#issuecomment-1812455103
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](map)fix map element_at with decimal value [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #27030:
URL: https://github.com/apache/doris/pull/27030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](map)fix map element_at with decimal value [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #27030:
URL: https://github.com/apache/doris/pull/27030#issuecomment-1813583209
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](map)fix map element_at with decimal value [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27030:
URL: https://github.com/apache/doris/pull/27030#issuecomment-1813726780
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit f8d216771e52380eeff679245cfbd19c3a99aa89, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4918 4661 4637 4637
q2 357 158 159 158
q3 2032 1860 1922 1860
q4 1382 1285 1273 1273
q5 3942 3940 4038 3940
q6 248 127 129 127
q7 1376 884 892 884
q8 2764 2806 2766 2766
q9 9730 9820 9604 9604
q10 3434 3517 3525 3517
q11 389 257 249 249
q12 442 303 295 295
q13 4576 3798 3777 3777
q14 314 301 297 297
q15 588 547 516 516
q16 668 583 584 583
q17 1140 999 917 917
q18 7799 7168 7406 7168
q19 1670 1667 1702 1667
q20 527 317 285 285
q21 4392 3995 3966 3966
q22 474 376 385 376
Total cold run time: 53162 ms
Total hot run time: 48862 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4597 4606 4569 4569
q2 334 229 253 229
q3 3985 3988 3983 3983
q4 2692 2685 2711 2685
q5 9517 9631 9683 9631
q6 242 126 125 125
q7 2590 2297 2306 2297
q8 4434 4458 4453 4453
q9 13223 13109 13008 13008
q10 4093 4133 4140 4133
q11 769 641 629 629
q12 986 827 800 800
q13 4303 3557 3541 3541
q14 380 342 340 340
q15 573 529 515 515
q16 742 680 668 668
q17 3859 3965 3855 3855
q18 9449 8960 9065 8960
q19 1848 1773 1781 1773
q20 2400 2101 2077 2077
q21 8825 8682 8499 8499
q22 874 796 836 796
Total cold run time: 80715 ms
Total hot run time: 77566 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](map)fix map element_at with decimal value [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27030:
URL: https://github.com/apache/doris/pull/27030#issuecomment-1813747019
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org