You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by traboukos <gi...@git.apache.org> on 2014/10/17 15:03:27 UTC

[GitHub] cordova-plugin-contacts pull request: Ds implement add to existing...

GitHub user traboukos opened a pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/48

    Ds implement add to existing contact

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/grgmo/cordova-plugin-contacts ds_implement_add_to_existing_contact

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-contacts/pull/48.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #48
    
----
commit e120fed1889f1843784c75f312294f96843dcc66
Author: grgmo <pg...@kentforlife.net>
Date:   2014-07-01T14:26:48Z

    get socialProfiles, all ims and phoneNumbers
    
    add socialProfiles
    
    missing ||
    
    messanger typo

commit 2b831ad209df3aa55289bf28e7829e884b6564f0
Author: grgmo <pg...@kentforlife.net>
Date:   2014-07-01T14:26:48Z

    get socialProfiles, all ims and phoneNumbers
    
    add socialProfiles
    
    missing ||
    
    messanger typo

commit ec367bdb2cb9c7da5c474cbb74de6cf10e244dc5
Author: grgmo <pg...@kentforlife.net>
Date:   2014-09-30T09:24:53Z

    update repo and fix conflicts

commit d4ed2f4c0b5741eb3782ce1b427d763ca3039ac2
Author: grgmo <pg...@kentforlife.net>
Date:   2014-07-01T14:26:48Z

    get socialProfiles, all ims and phoneNumbers
    
    add socialProfiles
    
    missing ||
    
    messanger typo

commit ee9c2884a408b7d4f3a242b65d89667d200340e5
Author: Dimitris Stefanidis <ds...@gmail.com>
Date:   2014-10-03T16:28:15Z

    Fix native add contact ui that was not working on iOS 7.0 and later
    
    Change to kABMultiStringPropertyType from kABPersonPhoneProperty in order to be ios 8.0 compatible.
    
    Handle case where null options are passed to the newContact function
    
    Move contact record creation in new function. New contact ui should be shown even when no params are passed
    
    Fix syntax errors and missing variables
    
    Make sure a dictionary is passed on the newContact command options

commit a67ed2ed7a4c78e74e41f7bbfd0f641b78184d5b
Author: aptheod <ap...@gmail.com>
Date:   2014-10-13T15:35:11Z

    Add android native UI methods for creating new contact and adding new phone number to already existing contact

commit eb294cf30727d36ed53f34935458e4691d118628
Author: Dimitris Stefanidis <ds...@gmail.com>
Date:   2014-10-17T12:54:43Z

    Merge branch 'master' of https://github.com/grgmo/cordova-plugin-contacts

commit ef83c2070aa6edd3776ea920d41e9a670974378a
Author: Dimitris Stefanidis <ds...@gmail.com>
Date:   2014-10-17T13:02:07Z

    Implement add to existing contact through native iOS ui

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-contacts pull request: Ds implement add to existing...

Posted by traboukos <gi...@git.apache.org>.
Github user traboukos closed the pull request at:

    https://github.com/apache/cordova-plugin-contacts/pull/48


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org