[GitHub] [beam] darshan-sj commented on a diff in pull request #26007: Adding support for Spanner Databoost in SpannerIO

["darshan-sj (via GitHub)" <gi...@apache.org>]

darshan-sj commented on code in PR #26007:
URL: https://github.com/apache/beam/pull/26007#discussion_r1155065856


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/BatchSpannerRead.java:
##########
@@ -138,6 +138,9 @@ public void processElement(ProcessContext c) throws Exception {
       BatchReadOnlyTransaction batchTx =
           spannerAccessor.getBatchClient().batchReadOnlyTransaction(tx.transactionId());
       ReadOperation op = c.element();
+      boolean dataBoostEnabled =
+          config.getDataBoostEnabled() != null
+              && Boolean.TRUE.equals(config.getDataBoostEnabled().get());

Review Comment:
   Since config.getDataBoostEnabled().get() is a Boolean, I thought it can be null as well. Thats why I wrote this way. Can it never be null?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org