You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/27 22:46:49 UTC
[GitHub] [incubator-superset] ktmud opened a new issue #11448: Refactor Cypress tests to make less page visits
ktmud opened a new issue #11448:
URL: https://github.com/apache/incubator-superset/issues/11448
**Is your feature request related to a problem? Please describe.**
Currently the Cypress tests are slow because many of them make new page requests for each test case.
**Describe the solution you'd like**
A lot of those are not really necessary and can be eliminated by combining similar tests on the same page to run consecutively. We should also add a section in CONTRIBUTING to describe how to write efficient E2E tests.
Making consecutive test cases on the same page also most closely simulate real user actions.
**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.
**Additional context**
For example, a lot of these `beforeEach` are not necessary:
<img src="https://user-images.githubusercontent.com/335541/97370050-65989d80-186b-11eb-8b39-834f66f533ae.png" width="400" />
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #11448: Refactor Cypress tests to make less page visits
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #11448:
URL: https://github.com/apache/incubator-superset/issues/11448#issuecomment-717584905
Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.97. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org