You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/27 16:41:52 UTC
[GitHub] [flink] gaborgsomogyi opened a new pull request, #21180: [FLINK-29783][Tests] Add some random to KafkaShuffleExactlyOnceITCasetopic names
gaborgsomogyi opened a new pull request, #21180:
URL: https://github.com/apache/flink/pull/21180
## What is the purpose of the change
`KafkaShuffleExactlyOnceITCasetopic.testAssignedToPartitionFailureRecoveryEventTime` fails with the following exception:
```
{code:java}
Oct 27 15:07:54 java.lang.AssertionError: Create test topic : partition_failure_recovery_EventTime failed, org.apache.kafka.common.errors.TopicExistsException: Topic 'partition_failure_recovery_EventTime' already exists.
Oct 27 15:07:54 at org.apache.flink.streaming.connectors.kafka.KafkaTestEnvironmentImpl.createTestTopic(KafkaTestEnvironmentImpl.java:207)
Oct 27 15:07:54 at org.apache.flink.streaming.connectors.kafka.KafkaTestEnvironment.createTestTopic(KafkaTestEnvironment.java:97)
Oct 27 15:07:54 at org.apache.flink.streaming.connectors.kafka.KafkaTestBase.createTestTopic(KafkaTestBase.java:217)
Oct 27 15:07:54 at org.apache.flink.streaming.connectors.kafka.shuffle.KafkaShuffleExactlyOnceITCase.testAssignedToPartitionFailureRecovery(KafkaShuffleExactlyOnceITCase.java:158)
Oct 27 15:07:54 at org.apache.flink.streaming.connectors.kafka.shuffle.KafkaShuffleExactlyOnceITCase.testAssignedToPartitionFailureRecoveryEventTime(KafkaShuffleExactlyOnceITCase.java:101)
Oct 27 15:07:54 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
Oct 27 15:07:54 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
Oct 27 15:07:54 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Oct 27 15:07:54 at java.lang.reflect.Method.invoke(Method.java:498)
Oct 27 15:07:54 at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
Oct 27 15:07:54 at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
Oct 27 15:07:54 at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
Oct 27 15:07:54 at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
Oct 27 15:07:54 at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
Oct 27 15:07:54 at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
Oct 27 15:07:54 at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
Oct 27 15:07:54 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
Oct 27 15:07:54 at java.lang.Thread.run(Thread.java:748)
{code}
```
I don't see any reason why multiple times the same topic would be created so what I assume is that somehow the test is executed multiple times within the JVM and Kafka instance is class bounded.
In the current PR I've made a quick fix to make this disappear and allow peoples to work on features.
## Brief change log
Added some random to KafkaShuffleExactlyOnceITCasetopic names.
## Verifying this change
Existing unit tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #21180: [FLINK-29783][tests] Add some random to KafkaShuffleExactlyOnceITCase topic names
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21180:
URL: https://github.com/apache/flink/pull/21180#issuecomment-1293903766
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #21180: [FLINK-29783][tests] Add some random to KafkaShuffleExactlyOnceITCase topic names
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21180:
URL: https://github.com/apache/flink/pull/21180#issuecomment-1293940368
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] mbalassi commented on pull request #21180: [FLINK-29783][tests] Add some random to KafkaShuffleExactlyOnceITCase topic names
Posted by GitBox <gi...@apache.org>.
mbalassi commented on PR #21180:
URL: https://github.com/apache/flink/pull/21180#issuecomment-1296277420
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #21180: [FLINK-29783][Tests] Add some random to KafkaShuffleExactlyOnceITCasetopic names
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21180:
URL: https://github.com/apache/flink/pull/21180#issuecomment-1293804227
Let's see whether it helps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21180: [FLINK-29783][Tests] Add some random to KafkaShuffleExactlyOnceITCasetopic names
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21180:
URL: https://github.com/apache/flink/pull/21180#issuecomment-1293803451
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ccc5e22c6617909e90705c11e4e28dfc12d9310b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ccc5e22c6617909e90705c11e4e28dfc12d9310b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ccc5e22c6617909e90705c11e4e28dfc12d9310b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi closed pull request #21180: [FLINK-29783][tests] Add some random to KafkaShuffleExactlyOnceITCase topic names
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi closed pull request #21180: [FLINK-29783][tests] Add some random to KafkaShuffleExactlyOnceITCase topic names
URL: https://github.com/apache/flink/pull/21180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaborgsomogyi commented on pull request #21180: [FLINK-29783][tests] Add some random to KafkaShuffleExactlyOnceITCase topic names
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #21180:
URL: https://github.com/apache/flink/pull/21180#issuecomment-1294990234
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org