You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bm...@apache.org on 2016/07/06 04:45:41 UTC

[4/4] mesos git commit: Fixed the docker executor to handle inspect failures.

Fixed the docker executor to handle inspect failures.

Review: https://reviews.apache.org/r/49674


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/d840f48f
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/d840f48f
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/d840f48f

Branch: refs/heads/master
Commit: d840f48f9a810b0a85d2cb0fd026759da2e673b6
Parents: de1fe25
Author: Benjamin Mahler <bm...@apache.org>
Authored: Tue Jul 5 17:16:00 2016 -0700
Committer: Benjamin Mahler <bm...@apache.org>
Committed: Tue Jul 5 21:39:41 2016 -0700

----------------------------------------------------------------------
 src/docker/executor.cpp | 9 +++++++++
 1 file changed, 9 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/d840f48f/src/docker/executor.cpp
----------------------------------------------------------------------
diff --git a/src/docker/executor.cpp b/src/docker/executor.cpp
index c53a008..6951104 100644
--- a/src/docker/executor.cpp
+++ b/src/docker/executor.cpp
@@ -208,6 +208,15 @@ public:
         return Nothing();
       }));
 
+    inspect.onFailed(defer(self(), [=](const string& failure) {
+      cerr << "Failed to inspect container '" << containerName << "'"
+           << ": " << failure << endl;
+
+      // TODO(bmahler): This is fatal, try to shut down cleanly.
+      // Since we don't have a container id, we can only discard
+      // the run future.
+    }));
+
     inspect.onReady(
         defer(self(), &Self::launchHealthCheck, containerName, task));
   }