You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/03/15 22:54:41 UTC

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5154: Fix the NPE for DISTINCT aggregation function when no record is selected

Jackie-Jiang opened a new pull request #5154: Fix the NPE for DISTINCT aggregation function when no record is selected
URL: https://github.com/apache/incubator-pinot/pull/5154
 
 
   When no record is selected for the whole table, column data type will be STRING for all distinct columns (by Pinot convention)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5154: Fix the NPE for DISTINCT aggregation function when no record is selected

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #5154: Fix the NPE for DISTINCT aggregation function when no record is selected
URL: https://github.com/apache/incubator-pinot/pull/5154#issuecomment-601421901
 
 
   Discussed offline. Will modify the test in another pr to cover different scenarios of empty response.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5154: Fix the NPE for DISTINCT aggregation function when no record is selected

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on a change in pull request #5154: Fix the NPE for DISTINCT aggregation function when no record is selected
URL: https://github.com/apache/incubator-pinot/pull/5154#discussion_r395221509
 
 

 ##########
 File path: pinot-core/src/test/java/org/apache/pinot/queries/DistinctQueriesTest.java
 ##########
 @@ -685,6 +694,18 @@ public void testDistinctWithFilter()
         sortedResults.add(new Record(new Object[]{"California", "San Mateo", 400000}));
         sortedResults.add(new Record(new Object[]{"California", "Sunnyvale", 300000}));
         runQueryInterSegmentWithOrderBy(orderByQuery, sortedResults, new String[]{"State", "City", "SaleAmount"});
+
+        String emptyResultQuery =
 
 Review comment:
   As long as it is using the `DistinctAggregationFunction.merge()` to merge the DistinctTables, it is handled. Check the fix in  `DistinctAggregationFunction.merge()`.
   Let me try to enhance the test to cover that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5154: Fix the NPE for DISTINCT aggregation function when no record is selected

Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on a change in pull request #5154: Fix the NPE for DISTINCT aggregation function when no record is selected
URL: https://github.com/apache/incubator-pinot/pull/5154#discussion_r394941552
 
 

 ##########
 File path: pinot-core/src/test/java/org/apache/pinot/queries/DistinctQueriesTest.java
 ##########
 @@ -685,6 +694,18 @@ public void testDistinctWithFilter()
         sortedResults.add(new Record(new Object[]{"California", "San Mateo", 400000}));
         sortedResults.add(new Record(new Object[]{"California", "Sunnyvale", 300000}));
         runQueryInterSegmentWithOrderBy(orderByQuery, sortedResults, new String[]{"State", "City", "SaleAmount"});
+
+        String emptyResultQuery =
 
 Review comment:
   We need to introduce some hacky way of knowing this scenario in the broker.reduce code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5154: Fix the NPE for DISTINCT aggregation function when no record is selected

Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on a change in pull request #5154: Fix the NPE for DISTINCT aggregation function when no record is selected
URL: https://github.com/apache/incubator-pinot/pull/5154#discussion_r394906767
 
 

 ##########
 File path: pinot-core/src/test/java/org/apache/pinot/queries/DistinctQueriesTest.java
 ##########
 @@ -685,6 +694,18 @@ public void testDistinctWithFilter()
         sortedResults.add(new Record(new Object[]{"California", "San Mateo", 400000}));
         sortedResults.add(new Record(new Object[]{"California", "Sunnyvale", 300000}));
         runQueryInterSegmentWithOrderBy(orderByQuery, sortedResults, new String[]{"State", "City", "SaleAmount"});
+
+        String emptyResultQuery =
 
 Review comment:
   I think this is the scenario when the overall result set of DISTINCT query at table level is empty and was throwing NPE as DistinctTable was null. 
   
   Can we please also add a test where the overall result at table level is non-empty but one or more segment returns empty?
   
   Then we have everything  covered.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5154: Fix the NPE for DISTINCT aggregation function when no record is selected

Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on a change in pull request #5154: Fix the NPE for DISTINCT aggregation function when no record is selected
URL: https://github.com/apache/incubator-pinot/pull/5154#discussion_r394907891
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionFactory.java
 ##########
 @@ -112,8 +111,10 @@ public static AggregationFunction getAggregationFunction(AggregationInfo aggrega
           case DISTINCTCOUNTRAWHLLMV:
             return new DistinctCountRawHLLMVAggregationFunction();
           case DISTINCT:
+            Preconditions.checkState(brokerRequest != null,
+                "Broker request must be provided for 'DISTINCT' aggregation function");
             return new DistinctAggregationFunction(AggregationFunctionUtils.getColumn(aggregationInfo),
-                brokerRequest != null ? brokerRequest.getLimit() : SelectAstNode.DEFAULT_RECORD_LIMIT, brokerRequest.getOrderBy());
+                brokerRequest.getOrderBy(), brokerRequest.getLimit());
 
 Review comment:
   I am unable to recall why I had this if check. I think there was a code-path where null broker request could have been passed. It is not possible right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5154: Fix the NPE for DISTINCT aggregation function when no record is selected

Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on a change in pull request #5154: Fix the NPE for DISTINCT aggregation function when no record is selected
URL: https://github.com/apache/incubator-pinot/pull/5154#discussion_r394941139
 
 

 ##########
 File path: pinot-core/src/test/java/org/apache/pinot/queries/DistinctQueriesTest.java
 ##########
 @@ -685,6 +694,18 @@ public void testDistinctWithFilter()
         sortedResults.add(new Record(new Object[]{"California", "San Mateo", 400000}));
         sortedResults.add(new Record(new Object[]{"California", "Sunnyvale", 300000}));
         runQueryInterSegmentWithOrderBy(orderByQuery, sortedResults, new String[]{"State", "City", "SaleAmount"});
+
+        String emptyResultQuery =
 
 Review comment:
   Now that I think more about it, I don't think this solution will work for the case when result from all segments on a single server is empty but across the servers is non empty. 
   
   The current solution would have sent. a Distinct table from the server with string types. However when the broker reduces distinct tables across server, it might choose the result column types as string if the server that sent empty distinct tables happens to be the 0th server. The broker has to decide the result column types for.the final response and it does that upfront by looking at the column types from first server's table since it assumes they will be the same (they should be in general cases except for this corner case). This will be wrong. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] codecov-io commented on issue #5154: Fix the NPE for DISTINCT aggregation function when no record is selected

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5154: Fix the NPE for DISTINCT aggregation function when no record is selected
URL: https://github.com/apache/incubator-pinot/pull/5154#issuecomment-599281290
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5154?src=pr&el=h1) Report
   > Merging [#5154](https://codecov.io/gh/apache/incubator-pinot/pull/5154?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/d989427ec076d4553206e9fdd062be24de50477d&el=desc) will **decrease** coverage by `0.10%`.
   > The diff coverage is `91.07%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/5154/graphs/tree.svg?width=650&height=150&src=pr&token=4ibza2ugkz)](https://codecov.io/gh/apache/incubator-pinot/pull/5154?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5154      +/-   ##
   ============================================
   - Coverage     66.10%   65.99%   -0.11%     
     Complexity       12       12              
   ============================================
     Files          1052     1052              
     Lines         54151    54139      -12     
     Branches       8081     8075       -6     
   ============================================
   - Hits          35796    35731      -65     
   - Misses        15690    15743      +53     
     Partials       2665     2665              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5154?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...aggregation/function/AggregationFunctionUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9BZ2dyZWdhdGlvbkZ1bmN0aW9uVXRpbHMuamF2YQ==) | `95.23% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...gregation/function/AggregationFunctionFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9BZ2dyZWdhdGlvbkZ1bmN0aW9uRmFjdG9yeS5qYXZh) | `80.39% <50.00%> (+0.39%)` | `0.00 <0.00> (ø)` | |
   | [...java/org/apache/pinot/common/utils/DataSchema.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvRGF0YVNjaGVtYS5qYXZh) | `85.29% <80.00%> (+0.03%)` | `0.00 <0.00> (ø)` | |
   | [...regation/function/DistinctAggregationFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9EaXN0aW5jdEFnZ3JlZ2F0aW9uRnVuY3Rpb24uamF2YQ==) | `77.08% <95.65%> (+3.75%)` | `0.00 <0.00> (ø)` | |
   | [...he/pinot/core/common/datatable/DataTableUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vZGF0YXRhYmxlL0RhdGFUYWJsZVV0aWxzLmphdmE=) | `90.36% <100.00%> (-0.45%)` | `0.00 <0.00> (ø)` | |
   | [...he/pinot/core/operator/CombineGroupByOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9Db21iaW5lR3JvdXBCeU9wZXJhdG9yLmphdmE=) | `83.69% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...rator/query/AggregationGroupByOrderByOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9xdWVyeS9BZ2dyZWdhdGlvbkdyb3VwQnlPcmRlckJ5T3BlcmF0b3IuamF2YQ==) | `92.30% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...t/core/plan/AggregationGroupByOrderByPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL0FnZ3JlZ2F0aW9uR3JvdXBCeU9yZGVyQnlQbGFuTm9kZS5qYXZh) | `31.25% <100.00%> (-1.41%)` | `0.00 <0.00> (ø)` | |
   | [...he/pinot/core/plan/AggregationGroupByPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL0FnZ3JlZ2F0aW9uR3JvdXBCeVBsYW5Ob2RlLmphdmE=) | `72.91% <100.00%> (-0.56%)` | `0.00 <0.00> (ø)` | |
   | [...rg/apache/pinot/core/plan/AggregationPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL0FnZ3JlZ2F0aW9uUGxhbk5vZGUuamF2YQ==) | `71.05% <100.00%> (-0.75%)` | `0.00 <0.00> (ø)` | |
   | ... and [35 more](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5154?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5154?src=pr&el=footer). Last update [d989427...8dd77cf](https://codecov.io/gh/apache/incubator-pinot/pull/5154?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5154: Fix the NPE for DISTINCT aggregation function when no record is selected

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on a change in pull request #5154: Fix the NPE for DISTINCT aggregation function when no record is selected
URL: https://github.com/apache/incubator-pinot/pull/5154#discussion_r395219463
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionFactory.java
 ##########
 @@ -112,8 +111,10 @@ public static AggregationFunction getAggregationFunction(AggregationInfo aggrega
           case DISTINCTCOUNTRAWHLLMV:
             return new DistinctCountRawHLLMVAggregationFunction();
           case DISTINCT:
+            Preconditions.checkState(brokerRequest != null,
+                "Broker request must be provided for 'DISTINCT' aggregation function");
             return new DistinctAggregationFunction(AggregationFunctionUtils.getColumn(aggregationInfo),
-                brokerRequest != null ? brokerRequest.getLimit() : SelectAstNode.DEFAULT_RECORD_LIMIT, brokerRequest.getOrderBy());
+                brokerRequest.getOrderBy(), brokerRequest.getLimit());
 
 Review comment:
   The existing code never works for `null` brokerRequest because `brokerRequest.getOrderBy()` will directly throw NPE. The broker aggregation reducer might call this without brokerRequest, but distinct is not using that code path to reduce the result.
   I added TODOs in `AggregationFunctionUtils` to always pass broker request for all code paths

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5154: Fix the NPE for DISTINCT aggregation function when no record is selected

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #5154: Fix the NPE for DISTINCT aggregation function when no record is selected
URL: https://github.com/apache/incubator-pinot/pull/5154#issuecomment-599281290
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5154?src=pr&el=h1) Report
   > Merging [#5154](https://codecov.io/gh/apache/incubator-pinot/pull/5154?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/d989427ec076d4553206e9fdd062be24de50477d&el=desc) will **decrease** coverage by `0.10%`.
   > The diff coverage is `91.07%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/5154/graphs/tree.svg?width=650&height=150&src=pr&token=4ibza2ugkz)](https://codecov.io/gh/apache/incubator-pinot/pull/5154?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5154      +/-   ##
   ============================================
   - Coverage     66.10%   65.99%   -0.11%     
     Complexity       12       12              
   ============================================
     Files          1052     1052              
     Lines         54151    54139      -12     
     Branches       8081     8075       -6     
   ============================================
   - Hits          35796    35731      -65     
   - Misses        15690    15743      +53     
     Partials       2665     2665              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5154?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...aggregation/function/AggregationFunctionUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9BZ2dyZWdhdGlvbkZ1bmN0aW9uVXRpbHMuamF2YQ==) | `95.23% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...gregation/function/AggregationFunctionFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9BZ2dyZWdhdGlvbkZ1bmN0aW9uRmFjdG9yeS5qYXZh) | `80.39% <50.00%> (+0.39%)` | `0.00 <0.00> (ø)` | |
   | [...java/org/apache/pinot/common/utils/DataSchema.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvRGF0YVNjaGVtYS5qYXZh) | `85.29% <80.00%> (+0.03%)` | `0.00 <0.00> (ø)` | |
   | [...regation/function/DistinctAggregationFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9EaXN0aW5jdEFnZ3JlZ2F0aW9uRnVuY3Rpb24uamF2YQ==) | `77.08% <95.65%> (+3.75%)` | `0.00 <0.00> (ø)` | |
   | [...he/pinot/core/common/datatable/DataTableUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vZGF0YXRhYmxlL0RhdGFUYWJsZVV0aWxzLmphdmE=) | `90.36% <100.00%> (-0.45%)` | `0.00 <0.00> (ø)` | |
   | [...he/pinot/core/operator/CombineGroupByOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9Db21iaW5lR3JvdXBCeU9wZXJhdG9yLmphdmE=) | `83.69% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...rator/query/AggregationGroupByOrderByOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9xdWVyeS9BZ2dyZWdhdGlvbkdyb3VwQnlPcmRlckJ5T3BlcmF0b3IuamF2YQ==) | `92.30% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...t/core/plan/AggregationGroupByOrderByPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL0FnZ3JlZ2F0aW9uR3JvdXBCeU9yZGVyQnlQbGFuTm9kZS5qYXZh) | `31.25% <100.00%> (-1.41%)` | `0.00 <0.00> (ø)` | |
   | [...he/pinot/core/plan/AggregationGroupByPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL0FnZ3JlZ2F0aW9uR3JvdXBCeVBsYW5Ob2RlLmphdmE=) | `72.91% <100.00%> (-0.56%)` | `0.00 <0.00> (ø)` | |
   | [...rg/apache/pinot/core/plan/AggregationPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL0FnZ3JlZ2F0aW9uUGxhbk5vZGUuamF2YQ==) | `71.05% <100.00%> (-0.75%)` | `0.00 <0.00> (ø)` | |
   | ... and [35 more](https://codecov.io/gh/apache/incubator-pinot/pull/5154/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5154?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5154?src=pr&el=footer). Last update [d989427...8dd77cf](https://codecov.io/gh/apache/incubator-pinot/pull/5154?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5154: Fix the NPE for DISTINCT aggregation function when no record is selected

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang merged pull request #5154: Fix the NPE for DISTINCT aggregation function when no record is selected
URL: https://github.com/apache/incubator-pinot/pull/5154
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org