Re: [PR] [SPARK-51272][CORE]. Fix for the race condition in Scheduler causing failure in retrying all partitions in case of indeterministic shuffle keys [spark]

["attilapiros (via GitHub)" <gi...@apache.org>]

attilapiros commented on code in PR #50033:
URL: https://github.com/apache/spark/pull/50033#discussion_r1978370699


##########
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala:
##########
@@ -81,6 +81,15 @@ class DAGSchedulerEventProcessLoopTester(dagScheduler: DAGScheduler)
     }
   }
 
+  def postInCurrentThread(event: DAGSchedulerEvent): Unit = {

Review Comment:
   This is not how the DAGScheduler processes the events. 
   The production code does it in a dedicated single thread for event processing called `dag-scheduler-event-loop`. 
   See `DAGSchedulerEventProcessLoop` for details.
   
   This way this reproduction is invalid. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org