[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #1962: [flink] CDC Ingestion options change did not trigger schema update

["JingsongLi (via GitHub)" <gi...@apache.org>]

JingsongLi commented on code in PR #1962:
URL: https://github.com/apache/incubator-paimon/pull/1962#discussion_r1321217041


##########
paimon-core/src/main/java/org/apache/paimon/tag/TagAutoCreation.java:
##########
@@ -109,8 +109,13 @@ private TagAutoCreation(
         } else {
             Snapshot lastTag = tags.lastKey();
             this.nextSnapshot = lastTag.id() + 1;
-
-            LocalDateTime time = periodHandler.tagToTime(tags.get(lastTag));
+            LocalDateTime time;
+            String lastTagValue = tags.get(lastTag);
+            if (periodHandler instanceof DailyTagPeriodHandler) {

Review Comment:
   Is here a test for this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org