You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by r-kamath <gi...@git.apache.org> on 2016/08/11 12:04:40 UTC

[GitHub] zeppelin pull request #1319: ZEPPELIN-1319 Use absolute path for ssl trustst...

GitHub user r-kamath opened a pull request:

    https://github.com/apache/zeppelin/pull/1319

    ZEPPELIN-1319 Use absolute path for ssl truststore and keystore when available

    ### What is this PR for?
    Use absolute path for ssl truststore and keystore when available
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1319
    
    ### How should this be tested?
    Config `zeppelin.ssl.truststore.path`, `zeppelin.ssl.keystore.path` and verify whether the absolute path or the path relative to conf is used.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? n/a
    * Is there breaking changes for older versions? n/a
    * Does this needs documentation? n/a


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/r-kamath/zeppelin ZEPPELIN-1319

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1319.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1319
    
----
commit fc2ac9f01e7712a8519b4b618f8b32d6d2be4390
Author: Renjith Kamath <re...@gmail.com>
Date:   2016-08-11T11:58:53Z

    ZEPPELIN-1319 Use absolute path for ssl truststore and keystore when available

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1319: ZEPPELIN-1319 Use absolute path for ssl truststore and...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/1319
  
    @corneadoug Yes, sure. Will merge this soon if no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1319: ZEPPELIN-1319 Use absolute path for ssl trustst...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1319


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1319: ZEPPELIN-1319 Use absolute path for ssl truststore and...

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the issue:

    https://github.com/apache/zeppelin/pull/1319
  
    @prabhjyotsingh Should we merge this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1319: ZEPPELIN-1319 Use absolute path for ssl truststore and...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/1319
  
    Good catch, LGTM!
    
    CI failure looks unrelated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---