[GitHub] mgodave commented on issue #1232: Schema registry (1/4)

[GitBox <gi...@apache.org>]

mgodave commented on issue #1232: Schema registry (1/4)
URL: https://github.com/apache/incubator-pulsar/pull/1232#issuecomment-369756569
 
 
   I added it then reverted it. I *think* we only need it on the server. We
   can tag messages as they come in and before we persist them to the topic,
   right? Even if that's the case it *might* be useful to return the version
   to the client.
   
   On Thu, Mar 1, 2018 at 2:56 PM, Matteo Merli <no...@github.com>
   wrote:
   
   > *@merlimat* commented on this pull request.
   > ------------------------------
   >
   > In pulsar-common/src/main/proto/PulsarApi.proto
   > <https://github.com/apache/incubator-pulsar/pull/1232#discussion_r171706547>
   > :
   >
   > > @@ -408,6 +408,7 @@ message CommandProducerSuccess {
   >  	// The last sequence id that was stored by this producer in the previous session
   >  	// This will only be meaningful if deduplication has been enabled.
   >  	optional int64  last_sequence_id = 3 [default = -1];
   > +	optional bytes schema_version = 4;
   >
   > @mgodave <https://github.com/mgodave> I think we need the schema_version
   > in producer_success. That should be attached to messages when publishing.
   >
   > ?
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-pulsar/pull/1232#pullrequestreview-100608456>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAh9Fl9jpkjSbk3j_h9vwhY9-abVOkB5ks5taG6igaJpZM4SEH6p>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services