[jira] [Commented] (ZOOKEEPER-1564) Allow JUnit test build with IBM Java

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528019#comment-13528019 ] 

Hadoop QA commented on ZOOKEEPER-1564:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12560191/ZOOKEEPER-1564-v3.patch
  against trunk revision 1418555.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 12 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1290//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1290//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1290//console

This message is automatically generated.
                
> Allow JUnit test build with IBM Java
> ------------------------------------
>
>                 Key: ZOOKEEPER-1564
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1564
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: tests
>    Affects Versions: 3.4.4, 3.5.0, 3.4.5
>         Environment: Linux, RHEL 6.3, IBM Java 6 SR 11
>            Reporter: Paulo Ricardo Paz Vital
>            Assignee: Paulo Ricardo Paz Vital
>              Labels: test
>             Fix For: 3.5.0, 3.4.6
>
>         Attachments: zookeeper-1564.patch, ZOOKEEPER-1564-v2.patch, ZOOKEEPER-1564-v3.patch
>
>
> The org.apache.zookeeper.test.ClientBase, org.apache.zookeeper.test.ClientTest, org.apache.zookeeper.test.QuorumBase and org.apache.zookeeper.test.QuorumUtil classes import the com.sun.management.UnixOperatingSystemMXBean class, that fail to build when using IBM Java 6 SR 11. This issue is resolved by new class OSMXBean class proposed in JIRA's ZOOKEEPER-1474.
> The class OSMXBean (org.apache.zookeeper.server.util.OSMXBean) is a wrapper for the implementation of com.sun.management.UnixOperatingSystemMXBean, and decides to use the SUN API or its own implementation depending on the runtime (vendor) used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira