[GitHub] [pulsar] lhotari opened a new pull request, #15384: [Broker] Fix typo in enum name and handle closing of the channel properly since writeAndFlush is asynchronous

[GitBox <gi...@apache.org>]

lhotari opened a new pull request, #15384:
URL: https://github.com/apache/pulsar/pull/15384

   ### Motivation
   
   There was a typo in the enum name `Sate` added in #10754 . The PR fixes the typo by renaming `Sate` to `State`.
   In addition, there's a slight refactoring to handle closing the channel after the writeAndFlush has completed. In practice this most likely doesn't make a difference.
   `ctx.channel().writeAndFlush` has been changed to `ctx.writeAndFlush`, since that's the usual way to write messages in the handler. 
   
   ### Modifications
   
   - rename `Sate` to `State`
   - `ctx.channel().writeAndFlush` -> `ctx.writeAndFlush`
   - use `.addListener(ChannelFutureListener.CLOSE)` to close the channel after the `.writeAndFlush` promise completes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Technoboy- merged pull request #15384: [Broker] Fix typo in enum name and handle closing of the channel properly since writeAndFlush is asynchronous

[GitBox <gi...@apache.org>]

Technoboy- merged PR #15384:
URL: https://github.com/apache/pulsar/pull/15384


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org