You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/28 14:53:34 UTC
[GitHub] [pulsar] gaoran10 opened a new pull request, #15371: [cherry-pick][pulsar-sql] Java version trim agent presto332 branch2.10
gaoran10 opened a new pull request, #15371:
URL: https://github.com/apache/pulsar/pull/15371
Fix #14951
# Motivation
The presto 332 couldn't parse Java version like this `11.0.14.1`, so add a Java version trim agent to walk around the problem.
This is a temporary patch, after the presto upgrade to 332+, we could remove this.
(cherry picked from commit a1aa18f1a856d074bb23d68f5c330d3558bdf6cb)
### Modifications
Add a Java version trim agent to format the system property `java.version` for the Pulsar SQL plugin.
### Verifying this change
This change is already covered by existing tests.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (yes)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `no-need-doc`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-added`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #15371: [cherry-pick][pulsar-sql] Java version trim agent presto332 branch2.10
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #15371:
URL: https://github.com/apache/pulsar/pull/15371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #15371: [cherry-pick][pulsar-sql] Java version trim agent presto332 branch2.10
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on code in PR #15371:
URL: https://github.com/apache/pulsar/pull/15371#discussion_r861441873
##########
tests/integration/src/test/java/org/apache/pulsar/tests/integration/suites/PulsarSQLTestSuite.java:
##########
@@ -23,6 +23,7 @@
import java.sql.SQLException;
import java.util.HashMap;
import java.util.Map;
+
Review Comment:
Delete this empty line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a diff in pull request #15371: [cherry-pick][pulsar-sql] Java version trim agent presto332 branch2.10
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on code in PR #15371:
URL: https://github.com/apache/pulsar/pull/15371#discussion_r864518156
##########
tests/integration/src/test/java/org/apache/pulsar/tests/integration/suites/PulsarSQLTestSuite.java:
##########
@@ -23,6 +23,7 @@
import java.sql.SQLException;
import java.util.HashMap;
import java.util.Map;
+
Review Comment:
fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org