You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/09/28 08:58:30 UTC
[GitHub] [commons-collections] berry120 opened a new pull request #256: SortedProperties should sort entrySet() as well as keys()
berry120 opened a new pull request #256:
URL: https://github.com/apache/commons-collections/pull/256
At present the `SortedProperties` class overrides & sorts in the `keys()` method, but not the `entrySet()` method. This leads to inconsistencies depending on how the properties are retrieved (for example, when calling `write()` to write the properties to a file, Java 8 uses `keyset()` but Java 11+ uses `entrySet()` - same for other methods like `list()`.)
This PR guarantees the same ordering on `keys()` as `entrySet()`, removing this inconsistency.
(First contribution to this repository, so please feel free to point me in the correct direction if something is wrong!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] garydgregory commented on pull request #256: SortedProperties should sort entrySet() as well as keys()
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #256:
URL: https://github.com/apache/commons-collections/pull/256#issuecomment-929195983
Thank you @berry120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] garydgregory merged pull request #256: SortedProperties should sort entrySet() as well as keys()
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #256:
URL: https://github.com/apache/commons-collections/pull/256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] garydgregory commented on pull request #256: SortedProperties should sort entrySet() as well as keys()
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #256:
URL: https://github.com/apache/commons-collections/pull/256#issuecomment-929195983
Thank you @berry120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] garydgregory merged pull request #256: SortedProperties should sort entrySet() as well as keys()
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #256:
URL: https://github.com/apache/commons-collections/pull/256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org