You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/12/27 10:13:30 UTC

[GitHub] [calcite] mgramin commented on pull request #2646: [CALCITE-4936] Generalize FilterCalcMergeRule and ProjectCalcMergeRule

mgramin commented on pull request #2646:
URL: https://github.com/apache/calcite/pull/2646#issuecomment-1001489758


   > General comment independent of this change: Do we really need `FilterCalcMergeRule` and `ProjectCalcMergeRule`? They look a bit redundant in the presence of `FilterToCalcRule` `ProjectToCalcRule` and `CalcMergeRule`.
   
   `FilterCalcMergeRule` and `ProjectCalcMergeRule` produce only `LogicalCalc` also, it can make further optimizations  more difficult.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org