You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2017/10/30 00:19:20 UTC

[GitHub] zeppelin pull request #2635: ZEPPELIN-3013. Only parse paragraph text when t...

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/2635

    ZEPPELIN-3013. Only parse paragraph text when text is updated

    ### What is this PR for?
    
    Before this PR, each time when paragraph use interpreter, it would parse the text to get the interpreter component which is inefficient. This PR would do it when `setText` is called. 
    
    
    ### What type of PR is it?
    [ Improvement | Refactoring]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3013
    
    ### How should this be tested?
    * Unit test is added
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3013

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2635.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2635
    
----
commit d9bd933d1ea2512b6768f54cffb0953ec54fc0db
Author: Jeff Zhang <zj...@apache.org>
Date:   2017-10-27T09:02:06Z

    ZEPPELIN-3013. Only parse paragraph text when text is updated

commit 781ec89626185e59f35532c53676add9660eb876
Author: Jeff Zhang <zj...@apache.org>
Date:   2017-10-29T12:41:52Z

    minor change

----


---

[GitHub] zeppelin issue #2635: ZEPPELIN-3013. Only parse paragraph text when text is ...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2635
  
    @felixcheung @prabhjyotsingh Could you help review it ? Thanks


---

[GitHub] zeppelin pull request #2635: ZEPPELIN-3013. Only parse paragraph text when t...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2635


---

[GitHub] zeppelin issue #2635: ZEPPELIN-3013. Only parse paragraph text when text is ...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2635
  
    Merge if no more comments


---