You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by graben <gi...@git.apache.org> on 2018/02/11 17:14:38 UTC
[GitHub] activemq-artemis pull request #1863: NO-JIRA: Sync OSGi broker config with l...
GitHub user graben opened a pull request:
https://github.com/apache/activemq-artemis/pull/1863
NO-JIRA: Sync OSGi broker config with latest changes from ARTEMIS-1628
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/graben/activemq-artemis master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1863.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1863
----
commit 5bd4ccc4e58bbc6f7d912ca2f0eead4d94968da2
Author: Benjamin Graf <be...@...>
Date: 2018-02-11T17:13:47Z
NO-JIRA: Sync OSGi broker config with latest changes from ARTEMIS-1628
----
---
[GitHub] activemq-artemis issue #1863: NO-JIRA: Sync OSGi broker config with latest c...
Posted by graben <gi...@git.apache.org>.
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/1863
Well, actually the broker.xml is build from several templates and snippets. OSGi needs a complete file to trigger broker deployment. Therefore a a file need to be constructed during build process. Meight be tricky.
---
[GitHub] activemq-artemis issue #1863: NO-JIRA: Sync OSGi broker config with latest c...
Posted by graben <gi...@git.apache.org>.
Github user graben commented on the issue:
https://github.com/apache/activemq-artemis/pull/1863
Any further objection to not merge this?
---
[GitHub] activemq-artemis pull request #1863: NO-JIRA: Sync OSGi broker config with l...
Posted by graben <gi...@git.apache.org>.
Github user graben commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1863#discussion_r167488780
--- Diff: artemis-features/src/main/resources/artemis.xml ---
@@ -196,5 +194,20 @@ under the License.
</addresses>
+
+ <!-- Uncomment the following if you want to use the Standard LoggingActiveMQServerPlugin pluging to log in events
--- End diff --
As mentioned before it's coming from default.
---
[GitHub] activemq-artemis pull request #1863: NO-JIRA: Sync OSGi broker config with l...
Posted by graben <gi...@git.apache.org>.
Github user graben commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1863#discussion_r167488412
--- Diff: artemis-features/src/main/resources/artemis.xml ---
@@ -32,21 +32,23 @@ under the License.
MAPPED: mmap files
NIO: Plain Java Files
-->
- <journal-type>ASYNCIO</journal-type>
+ <journal-type>NIO</journal-type>
--- End diff --
Well, I synced with a created default broker.xml its default is actually NIO and avoid "urgly" comments on every broker start if asyncio is not supported
---
[GitHub] activemq-artemis pull request #1863: NO-JIRA: Sync OSGi broker config with l...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1863#discussion_r167473570
--- Diff: artemis-features/src/main/resources/artemis.xml ---
@@ -32,21 +32,23 @@ under the License.
MAPPED: mmap files
NIO: Plain Java Files
-->
- <journal-type>ASYNCIO</journal-type>
+ <journal-type>NIO</journal-type>
- <paging-directory>./data/artemis/paging</paging-directory>
+ <paging-directory>./paging</paging-directory>
--- End diff --
Why change this?
---
[GitHub] activemq-artemis pull request #1863: NO-JIRA: Sync OSGi broker config with l...
Posted by graben <gi...@git.apache.org>.
Github user graben commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1863#discussion_r167488599
--- Diff: artemis-features/src/main/resources/artemis.xml ---
@@ -32,21 +32,23 @@ under the License.
MAPPED: mmap files
NIO: Plain Java Files
-->
- <journal-type>ASYNCIO</journal-type>
+ <journal-type>NIO</journal-type>
- <paging-directory>./data/artemis/paging</paging-directory>
+ <paging-directory>./paging</paging-directory>
--- End diff --
root directory is data/artemis/<brokername>. This avoid data/artemis to be used unnecessary twice.
---
[GitHub] activemq-artemis pull request #1863: NO-JIRA: Sync OSGi broker config with l...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1863
---
[GitHub] activemq-artemis pull request #1863: NO-JIRA: Sync OSGi broker config with l...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1863#discussion_r167473634
--- Diff: artemis-features/src/main/resources/artemis.xml ---
@@ -196,5 +194,20 @@ under the License.
</addresses>
+
+ <!-- Uncomment the following if you want to use the Standard LoggingActiveMQServerPlugin pluging to log in events
--- End diff --
Why add this?
---
[GitHub] activemq-artemis pull request #1863: NO-JIRA: Sync OSGi broker config with l...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1863#discussion_r167473549
--- Diff: artemis-features/src/main/resources/artemis.xml ---
@@ -32,21 +32,23 @@ under the License.
MAPPED: mmap files
NIO: Plain Java Files
-->
- <journal-type>ASYNCIO</journal-type>
+ <journal-type>NIO</journal-type>
--- End diff --
ASYNCIO should be the default it’s more performant and Artemis will fall back to NIO if not present
---
[GitHub] activemq-artemis issue #1863: NO-JIRA: Sync OSGi broker config with latest c...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1863
Is there no option to just copy (or build) this file from the source so manual syncing isn't necessary?
---