You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Luis De Pombo <lf...@gmail.com> on 2015/07/07 21:08:12 UTC
Review Request 36274: SAMZA-401: getCpuTime to truly calculate duty
cycle of the event loop
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36274/
-----------------------------------------------------------
Review request for samza.
Repository: samza
Description
-------
SAMZA-401: getCpuTime to truly calculate duty cycle of the event loop
Diffs
-----
samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala c292ae47cd89ef0f25dc682c02dd288e2ba6dcc5
samza-core/src/main/scala/org/apache/samza/util/TimerUtils.scala 1643070dd710efb9ade9eb5812dabd6fa60ce023
samza-core/src/main/scala/org/apache/samza/util/Util.scala 2feb65b729b45fbc3b83a75c4072527e3c4e60be
samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala 64a5844bdb343a3c509cba059b9f3b9a19dc9eff
Diff: https://reviews.apache.org/r/36274/diff/
Testing
-------
Thanks,
Luis De Pombo
Re: Review Request 36274: SAMZA-401: getCpuTime to truly calculate
duty cycle of the event loop
Posted by Yan Fang <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36274/#review91527
-----------------------------------------------------------
samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala (lines 75 - 76)
<https://reviews.apache.org/r/36274/#comment144953>
for more accurate, I think the activeNs should go before totalNs.
- Yan Fang
On July 7, 2015, 7:08 p.m., Luis De Pombo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36274/
> -----------------------------------------------------------
>
> (Updated July 7, 2015, 7:08 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-401: getCpuTime to truly calculate duty cycle of the event loop
>
>
> Diffs
> -----
>
> samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala c292ae47cd89ef0f25dc682c02dd288e2ba6dcc5
> samza-core/src/main/scala/org/apache/samza/util/TimerUtils.scala 1643070dd710efb9ade9eb5812dabd6fa60ce023
> samza-core/src/main/scala/org/apache/samza/util/Util.scala 2feb65b729b45fbc3b83a75c4072527e3c4e60be
> samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala 64a5844bdb343a3c509cba059b9f3b9a19dc9eff
>
> Diff: https://reviews.apache.org/r/36274/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Luis De Pombo
>
>