You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/03/10 15:26:22 UTC
[GitHub] [iceberg] XN137 opened a new pull request #4306: Build: Upgrade to Gradle 7.4.1
XN137 opened a new pull request #4306:
URL: https://github.com/apache/iceberg/pull/4306
https://docs.gradle.org/7.4.1/release-notes.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] snazy commented on pull request #4306: Build: Upgrade to Gradle 7.4.1
Posted by GitBox <gi...@apache.org>.
snazy commented on pull request #4306:
URL: https://github.com/apache/iceberg/pull/4306#issuecomment-1065860588
It’s not a big deal to keep Gradle up to date and get bug fixes before we run into potential build issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4306: Build: Upgrade to Gradle 7.4.1
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4306:
URL: https://github.com/apache/iceberg/pull/4306#issuecomment-1065580678
Do we need to continuously upgrade gradle minor versions? Is there a benefit to doing this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #4306: Build: Upgrade to Gradle 7.4.1
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #4306:
URL: https://github.com/apache/iceberg/pull/4306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] snazy commented on a change in pull request #4306: Build: Upgrade to Gradle 7.4.1
Posted by GitBox <gi...@apache.org>.
snazy commented on a change in pull request #4306:
URL: https://github.com/apache/iceberg/pull/4306#discussion_r824751903
##########
File path: gradlew
##########
@@ -83,7 +83,7 @@ done
APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit
if [ ! -e $APP_HOME/gradle/wrapper/gradle-wrapper.jar ]; then
- curl -o $APP_HOME/gradle/wrapper/gradle-wrapper.jar https://raw.githubusercontent.com/gradle/gradle/v7.4.0/gradle/wrapper/gradle-wrapper.jar
+ curl -o $APP_HOME/gradle/wrapper/gradle-wrapper.jar https://raw.githubusercontent.com/gradle/gradle/v7.4.1/gradle/wrapper/gradle-wrapper.jar
Review comment:
Yes - the wrapper jar's only in the full gradle distribution.
The recommended way is to put the wrapper jar into the git (but we won't have that here).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] XN137 commented on a change in pull request #4306: Build: Upgrade to Gradle 7.4.1
Posted by GitBox <gi...@apache.org>.
XN137 commented on a change in pull request #4306:
URL: https://github.com/apache/iceberg/pull/4306#discussion_r823842642
##########
File path: gradlew
##########
@@ -83,7 +83,7 @@ done
APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit
if [ ! -e $APP_HOME/gradle/wrapper/gradle-wrapper.jar ]; then
- curl -o $APP_HOME/gradle/wrapper/gradle-wrapper.jar https://raw.githubusercontent.com/gradle/gradle/v7.4.0/gradle/wrapper/gradle-wrapper.jar
+ curl -o $APP_HOME/gradle/wrapper/gradle-wrapper.jar https://raw.githubusercontent.com/gradle/gradle/v7.4.1/gradle/wrapper/gradle-wrapper.jar
Review comment:
i would like to note that this does not get the wrapper jar of 7.4.1 but just the wrapper jar the gradle project itself happened to use at the time of the tag:
https://github.com/gradle/gradle/tree/v7.4.1/gradle/wrapper
yet there doesnt seem to be any official wrapper jar download url.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org