You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "tdiesler (via GitHub)" <gi...@apache.org> on 2024/08/09 15:03:56 UTC

[PR] Camel 21063 [camel]

tdiesler opened a new pull request, #15086:
URL: https://github.com/apache/camel/pull/15086

   https://issues.apache.org/jira/browse/CAMEL-21063


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CAMEL-21063] Uniformly provide a heath endpoint for exported cloud projects [camel]

Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #15086:
URL: https://github.com/apache/camel/pull/15086#issuecomment-2279420811

   > TODO: We need to look at the export main as it seems to be broken during my PTO.
   > 
   > The main export was working fine before and uses jkube and jib.
   > 
   > We need to look at this again and make sure it works as before in the 4.7.0 release.
   
   BTW, this raises the alarm that with all these new code getting into Camel JBang we might need to reinforce our test coverage on this component. Being a tool, it's probably a lot harder to test than regular components, but I think we might come up with something if we brainstorm it. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CAMEL-21063] Uniformly provide a heath endpoint for exported cloud projects [camel]

Posted by "christophd (via GitHub)" <gi...@apache.org>.
christophd commented on code in PR #15086:
URL: https://github.com/apache/camel/pull/15086#discussion_r1714925728


##########
dsl/camel-jbang/camel-jbang-plugin-kubernetes/src/main/java/org/apache/camel/dsl/jbang/core/commands/kubernetes/KubernetesExport.java:
##########
@@ -109,7 +109,7 @@ public class KubernetesExport extends Export {
                         description = "The image registry group used to push images to.")
     protected String imageGroup;
 
-    @CommandLine.Option(names = { "--image-builder" },
+    @CommandLine.Option(names = { "--image-builder" }, defaultValue = "docker",

Review Comment:
   why not keep jib as the default image builder? Jib does not require users to install a Docker deamon



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CAMEL-21063] Uniformly provide a heath endpoint for exported cloud projects [camel]

Posted by "tdiesler (via GitHub)" <gi...@apache.org>.
tdiesler closed pull request #15086: [CAMEL-21063] Uniformly provide a heath endpoint for exported cloud projects
URL: https://github.com/apache/camel/pull/15086


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CAMEL-21063] Uniformly provide a heath endpoint for exported cloud projects [camel]

Posted by "tdiesler (via GitHub)" <gi...@apache.org>.
tdiesler commented on PR #15086:
URL: https://github.com/apache/camel/pull/15086#issuecomment-2278548991

   This PR restores the health endpoints in the k8s export layer (they used to be there by default).
   
   To build with jib, you can use the `--image-builder=jib` property, 'docker' is the default. Building with jib requires `--image-registry` - currently this doesn't push automatically. The work with jkube/openshift is in progress.
   
   Could you pls be a little more specific about 'seems to be broken' and 'works as before'? Apparently, improving the test coverage is needed too.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CAMEL-21063] Uniformly provide a heath endpoint for exported cloud projects [camel]

Posted by "tdiesler (via GitHub)" <gi...@apache.org>.
tdiesler commented on PR #15086:
URL: https://github.com/apache/camel/pull/15086#issuecomment-2285765103

   Needs to get revisited. We want health endpoint with `camel kubernetes export` but not necessarily for plain `camel export`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org