You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Yu Ishikawa (JIRA)" <ji...@apache.org> on 2017/06/19 17:41:00 UTC
[jira] [Updated] (AIRFLOW-1323) Operators related to Dataproc
should keep consistency with the connection ID paramter
[ https://issues.apache.org/jira/browse/AIRFLOW-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yu Ishikawa updated AIRFLOW-1323:
---------------------------------
Description:
The parameters of {{DataprocClusterDeleteOperator}} and {{DataprocClusterCreateOperator}} for GCP connection ID are {{google_cloud_conn_id}}. On the other hand, for example,
{{DataProcPigOperator}}'s paramter is {{gcp_conn_id}}. I think this inconsistency may make users confused. We should keep the parameter's name consistent.
- https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/operators/dataproc_operator.py#L58
- https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/operators/dataproc_operator.py#L626
was:
The parameters of {{DataprocClusterDeleteOperator}} and {{DataprocClusterCreateOperator}} for GCP connection ID are {{google_cloud_conn_id}}. On the other hand, for example,
{{DataProcPigOperator}}'s paramter is {{gcp_conn_id}}. I think this inconsistency may make users confused. We should keep the parameter's name consistent.
> Operators related to Dataproc should keep consistency with the connection ID paramter
> -------------------------------------------------------------------------------------
>
> Key: AIRFLOW-1323
> URL: https://issues.apache.org/jira/browse/AIRFLOW-1323
> Project: Apache Airflow
> Issue Type: Improvement
> Components: operators
> Reporter: Yu Ishikawa
> Priority: Minor
>
> The parameters of {{DataprocClusterDeleteOperator}} and {{DataprocClusterCreateOperator}} for GCP connection ID are {{google_cloud_conn_id}}. On the other hand, for example,
> {{DataProcPigOperator}}'s paramter is {{gcp_conn_id}}. I think this inconsistency may make users confused. We should keep the parameter's name consistent.
> - https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/operators/dataproc_operator.py#L58
> - https://github.com/apache/incubator-airflow/blob/master/airflow/contrib/operators/dataproc_operator.py#L626
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)