You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "LiZhenNet (GitHub)" <gi...@apache.org> on 2018/12/18 12:49:29 UTC
[GitHub] [incubator-dubbo] LiZhenNet opened pull request #3007:
Telnet use Exporter's key to find the Exporter
## What is the purpose of the change
Fix https://github.com/apache/incubator-dubbo/issues/2988
Telnet use Exporter's key to find the Exporter . Not used getSimpleName or InterfaceName, because they are not unique, Exporter's key is unique to one Exporter。
## Brief changelog
Telnet use Exporter's key to find the Exporter
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3007 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] LiZhenNet closed pull request #3007:
Telnet use Exporter's key to find the Exporter
Posted by "LiZhenNet (GitHub)" <gi...@apache.org>.
[ pull request closed by LiZhenNet ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3007 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 commented on issue #3007: Telnet
use Exporter's key to find the Exporter
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
We should not rely on DubboProtocol any longer. Would you mind to take a look at #3013?
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3007 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] LiZhenNet commented on issue #3007: Telnet
use Exporter's key to find the Exporter
Posted by "LiZhenNet (GitHub)" <gi...@apache.org>.
> We should not rely on DubboProtocol any longer. Would you mind to take a look at #3013?
seems more graceful !
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3007 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org