You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2017/09/14 06:13:02 UTC

[jira] [Reopened] (HBASE-18772) [JDK8] Replace AtomicLong with LongAdder

     [ https://issues.apache.org/jira/browse/HBASE-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack reopened HBASE-18772:
---------------------------

Reopen

On master branch I get this:

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.hadoop.hbase.ipc.TestSimpleRpcScheduler
Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 8.183 sec <<< FAILURE! - in org.apache.hadoop.hbase.ipc.TestSimpleRpcScheduler
testCoDelScheduling(org.apache.hadoop.hbase.ipc.TestSimpleRpcScheduler)  Time elapsed: 0.191 sec  <<< ERROR!
java.lang.UnsupportedOperationException: Unable to find suitable constructor for class org.apache.hadoop.hbase.ipc.AdaptiveLifoCoDelCallQueue
	at org.apache.hadoop.hbase.ipc.TestSimpleRpcScheduler.testCoDelScheduling(TestSimpleRpcScheduler.java:444)


Results :

Tests in error:
  TestSimpleRpcScheduler.testCoDelScheduling:444 » UnsupportedOperation Unable t...

Tests run: 7, Failures: 0, Errors: 1, Skipped: 0


Its an ugly failure because we spec rpcexecutor with atomiclongs and the constructor was changed to longadder... but we get there via reflection.

> [JDK8]  Replace AtomicLong with LongAdder
> -----------------------------------------
>
>                 Key: HBASE-18772
>                 URL: https://issues.apache.org/jira/browse/HBASE-18772
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha-2
>            Reporter: Yechao Chen
>            Assignee: Yechao Chen
>            Priority: Trivial
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-18772.master.patch, HBASE-18772.master-v2.patch, HBASE-18772.master-v3.patch, HBASE-18772.master-v4.patch
>
>
> Currently we use many AtomicLong in HBase Region Code ,such as BucketCache calss realCacheSize,heapSize,blockNumber,accessCount  and HRegion calss  compactionNumBytesCompacted etc .
> In JDK8 LongAdder  is faster than AtomicLong ,should use this replace  AtomicLong 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)