[GitHub] [jclouds] gaul commented on a change in pull request #23: draft - disable AccessPolicy check for SAS Authorised azureblob

[GitBox <gi...@apache.org>]

gaul commented on a change in pull request #23: draft - disable AccessPolicy check for SAS Authorised azureblob
URL: https://github.com/apache/jclouds/pull/23#discussion_r286852953
 
 

 ##########
 File path: providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/functions/BlobPropertiesToBlobMetadata.java
 ##########
 @@ -58,8 +61,9 @@ public MutableBlobMetadata apply(BlobProperties from) {
             PublicAccess containerAcl = containerAcls.getUnchecked(from.getContainer());
             if (containerAcl != PublicAccess.PRIVATE)
                to.setPublicUri(from.getUrl());
-         } catch (CacheLoader.InvalidCacheLoadException e) {
-            // nulls not permitted from cache loader
+         } catch (Exception ex) {
+            InsufficientAccessRightsException iare = Throwables2.getFirstThrowableOfType(ex, InsufficientAccessRightsException.class);
+            if (iare == null) throw ex;  
 
 Review comment:
   Maybe add a comment explaining that this is not a publicly accessible object?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services