You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by CodingCat <gi...@git.apache.org> on 2015/03/20 02:29:48 UTC
[GitHub] spark pull request: [SPARK-6422][STREAMING] support customized act...
GitHub user CodingCat opened a pull request:
https://github.com/apache/spark/pull/5098
[SPARK-6422][STREAMING] support customized actor system for actor-based receiver
https://issues.apache.org/jira/browse/SPARK-6422
To disable the Akka's fault detection system, we currently set large default values for Akka' transport failure detector threshold and heartbeat interval, and discourage users to customize these values..
Meanwhile, we are trying to eliminate the dependency to Akka, e.g. we are trying to implement a general RPC interface (https://github.com/apache/spark/pull/4588), etc.
Based on the above facts, enabling a customized Akka system for actor-based receiver has at least two benefits:
1. users can easily set values related to failure detector which are more practical in general Akka usage scenario;
2. reduce the dependency level to Akka, (in future, we can even move Actor-based receiver to external project)
This patch proposes to enable the user to be able to configure the customized Akka system by passing `spark.streaming.receiver.akka.*` parameters...if these parameters do not exist, then we fall back to the Spark's Actor System
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/CodingCat/spark SPARK-6422
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5098.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5098
----
commit 2f7358b70a027472f1e1f7bbb2db4fd3c95782d3
Author: CodingCat <zh...@gmail.com>
Date: 2015-03-20T01:25:37Z
support customized actor system for actor-based receiver
commit 0bffc4d4853edee5b846506274e43a8ecf134c01
Author: CodingCat <zh...@gmail.com>
Date: 2015-03-20T01:30:08Z
the user can also use Spark's actor system
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6422][STREAMING] support customized act...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5098#issuecomment-83867831
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28901/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6422][STREAMING] support customized act...
Posted by CodingCat <gi...@git.apache.org>.
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/5098#issuecomment-83841718
This patch is open to further steps, e.g. directly to move Actor-based receiver to external
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6422][STREAMING] support customized act...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5098#issuecomment-83867813
[Test build #28901 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28901/consoleFull) for PR 5098 at commit [`4fe04ee`](https://github.com/apache/spark/commit/4fe04ee69cb9f70e2156f18aa59c13774e39a009).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6422][STREAMING] support customized act...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5098#issuecomment-83842787
[Test build #28901 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28901/consoleFull) for PR 5098 at commit [`4fe04ee`](https://github.com/apache/spark/commit/4fe04ee69cb9f70e2156f18aa59c13774e39a009).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6422][STREAMING] support customized act...
Posted by CodingCat <gi...@git.apache.org>.
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/5098#issuecomment-83842488
@tdas, would you mind taking a review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6422][STREAMING] support customized act...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/5098#issuecomment-136916012
@CodingCat elsewhere in the code base we're moving away from the Akka framework, so it makes less sense to do this now than before. I believe this patch is no longer applicable given efforts like SPARK-6028. Would you mind closing this patch? Thanks for your work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6422][STREAMING] support customized act...
Posted by CodingCat <gi...@git.apache.org>.
Github user CodingCat closed the pull request at:
https://github.com/apache/spark/pull/5098
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6422][STREAMING] support customized act...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5098#issuecomment-96770050
[Test build #31049 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31049/consoleFull) for PR 5098 at commit [`4fe04ee`](https://github.com/apache/spark/commit/4fe04ee69cb9f70e2156f18aa59c13774e39a009).
* This patch **does not merge cleanly**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6422][STREAMING] support customized act...
Posted by CodingCat <gi...@git.apache.org>.
Github user CodingCat commented on the pull request:
https://github.com/apache/spark/pull/5098#issuecomment-136916265
yeah, once https://github.com/apache/spark/pull/6841 gets merged, this is no longer necessary.....
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6422][STREAMING] support customized act...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5098#issuecomment-96804955
[Test build #31049 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31049/consoleFull) for PR 5098 at commit [`4fe04ee`](https://github.com/apache/spark/commit/4fe04ee69cb9f70e2156f18aa59c13774e39a009).
* This patch **passes all tests**.
* This patch **does not merge cleanly**.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org