You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "John Heitmann (JIRA)" <ji...@apache.org> on 2006/08/22 09:50:23 UTC
[jira] Created: (AMQ-891) InterruptedException handling tweaks
InterruptedException handling tweaks
------------------------------------
Key: AMQ-891
URL: https://issues.apache.org/activemq/browse/AMQ-891
Project: ActiveMQ
Issue Type: Bug
Components: Broker
Affects Versions: 4.0.2
Reporter: John Heitmann
Priority: Minor
Attachments: interrupted.patch.gz
There were a few spots where the broker was masking the interrupt state after handling an InterruptedException. This is a lint pass to clean some of that up. I learned after I made this patch that it's actually slightly better stylistically to call Thread.interrupt() instead of Thread.currentThread().interrupt() since it's static and the interrupt state is global(ish), but this is the version we've tested.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (AMQ-891) InterruptedException handling tweaks
Posted by "james strachan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-891?page=all ]
james strachan reassigned AMQ-891:
----------------------------------
Assignee: Hiram Chirino
Do you wanna handle this one - I seem to remember you doing some work on the interupted stuff?
> InterruptedException handling tweaks
> ------------------------------------
>
> Key: AMQ-891
> URL: https://issues.apache.org/activemq/browse/AMQ-891
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 4.0.2
> Reporter: John Heitmann
> Assigned To: Hiram Chirino
> Priority: Minor
> Attachments: interrupted.patch.gz
>
>
> There were a few spots where the broker was masking the interrupt state after handling an InterruptedException. This is a lint pass to clean some of that up. I learned after I made this patch that it's actually slightly better stylistically to call Thread.interrupt() instead of Thread.currentThread().interrupt() since it's static and the interrupt state is global(ish), but this is the version we've tested.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (AMQ-891) InterruptedException handling tweaks
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-891?page=all ]
Hiram Chirino resolved AMQ-891.
-------------------------------
Fix Version/s: 4.1
4.0.2
Resolution: Fixed
Great patch! Applied to trunk rev 439886 and to 4.0 branch rev 439941
> InterruptedException handling tweaks
> ------------------------------------
>
> Key: AMQ-891
> URL: https://issues.apache.org/activemq/browse/AMQ-891
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 4.0.2
> Reporter: John Heitmann
> Assigned To: Hiram Chirino
> Priority: Minor
> Fix For: 4.1, 4.0.2
>
> Attachments: interrupted.patch.gz
>
>
> There were a few spots where the broker was masking the interrupt state after handling an InterruptedException. This is a lint pass to clean some of that up. I learned after I made this patch that it's actually slightly better stylistically to call Thread.interrupt() instead of Thread.currentThread().interrupt() since it's static and the interrupt state is global(ish), but this is the version we've tested.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira