You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@metamodel.apache.org by kaspersorensen <gi...@git.apache.org> on 2015/08/12 22:57:40 UTC

[GitHub] metamodel pull request: METAMODEL-164: Fixed and refactored ES map...

GitHub user kaspersorensen opened a pull request:

    https://github.com/apache/metamodel/pull/38

    METAMODEL-164: Fixed and refactored ES mapping parser to use real map.

    Previously the parser was (by accident I think) using the toString()
    representation of that same map which made it very vulnerable towards
    parsing issues.
    
    Fixes METAMODEL-164

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kaspersorensen/metamodel METAMODEL-164

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metamodel/pull/38.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #38
    
----
commit 6f4958f1e916c8cf4560da8cb04cfb53ff578764
Author: Kasper Sørensen <i....@gmail.com>
Date:   2015-08-12T20:56:52Z

    METAMODEL-164: Fixed and refactored ES mapping parser to use real map.
    
    Previously the parser was (by accident I think) using the toString()
    representation of that same map which made it very vulnerable towards
    parsing issues.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metamodel pull request: METAMODEL-164: Fixed and refactored ES map...

Posted by LosD <gi...@git.apache.org>.

Github user LosD commented on the pull request:

    https://github.com/apache/metamodel/pull/38#issuecomment-130722508
  
    LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metamodel pull request: METAMODEL-164: Fixed and refactored ES map...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/metamodel/pull/38


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---