You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2020/01/28 01:42:34 UTC

[hbase] branch branch-2 updated: HBASE-23746 [Flakey Tests] Caused by: org.apache.hadoop.hbase.util.CommonFSUtils$StreamLacksCapabilityException: hflush and hsync; ADDENDUM add a few more tests

This is an automated email from the ASF dual-hosted git repository.

stack pushed a commit to branch branch-2
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-2 by this push:
     new 2d5dfeb  HBASE-23746 [Flakey Tests] Caused by: org.apache.hadoop.hbase.util.CommonFSUtils$StreamLacksCapabilityException: hflush and hsync; ADDENDUM add a few more tests
2d5dfeb is described below

commit 2d5dfebb858335c2173cf0ff2a6416ca9270865b
Author: stack <st...@apache.org>
AuthorDate: Mon Jan 27 17:42:08 2020 -0800

    HBASE-23746 [Flakey Tests] Caused by: org.apache.hadoop.hbase.util.CommonFSUtils$StreamLacksCapabilityException: hflush and hsync; ADDENDUM add a few more tests
---
 .../hbase/procedure2/store/region/RegionProcedureStoreTestBase.java   | 4 ++++
 .../procedure2/store/region/TestRegionProcedureStoreMigration.java    | 2 ++
 .../procedure2/store/region/TestRegionProcedureStoreWALCleaner.java   | 2 ++
 3 files changed, 8 insertions(+)

diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStoreTestBase.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStoreTestBase.java
index 3ffadf6..dde04a4 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStoreTestBase.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStoreTestBase.java
@@ -29,6 +29,10 @@ import org.apache.hadoop.hbase.util.CommonFSUtils;
 import org.junit.After;
 import org.junit.Before;
 
+/**
+ * This runs on local filesystem. hsync and hflush are not supported. May lose data!
+ * Only use where data loss is not of consequence.
+ */
 public class RegionProcedureStoreTestBase {
 
   protected HBaseCommonTestingUtility htu;
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/procedure2/store/region/TestRegionProcedureStoreMigration.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/procedure2/store/region/TestRegionProcedureStoreMigration.java
index 9a49361..0dc718b 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/procedure2/store/region/TestRegionProcedureStoreMigration.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/procedure2/store/region/TestRegionProcedureStoreMigration.java
@@ -78,6 +78,8 @@ public class TestRegionProcedureStoreMigration {
     htu = new HBaseCommonTestingUtility();
     Configuration conf = htu.getConfiguration();
     conf.setBoolean(MemStoreLAB.USEMSLAB_KEY, false);
+    // Runs on local filesystem. Test does not need sync. Turn off checks.
+    htu.getConfiguration().setBoolean(CommonFSUtils.UNSAFE_STREAM_CAPABILITY_ENFORCE, false);
     Path testDir = htu.getDataTestDir();
     CommonFSUtils.setWALRootDir(conf, testDir);
     walStore = new WALProcedureStore(conf, new LeaseRecovery() {
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/procedure2/store/region/TestRegionProcedureStoreWALCleaner.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/procedure2/store/region/TestRegionProcedureStoreWALCleaner.java
index db49942..b4290da 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/procedure2/store/region/TestRegionProcedureStoreWALCleaner.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/procedure2/store/region/TestRegionProcedureStoreWALCleaner.java
@@ -72,6 +72,8 @@ public class TestRegionProcedureStoreWALCleaner {
     htu = new HBaseCommonTestingUtility();
     Configuration conf = htu.getConfiguration();
     conf.setBoolean(MemStoreLAB.USEMSLAB_KEY, false);
+    // Runs on local filesystem. Test does not need sync. Turn off checks.
+    htu.getConfiguration().setBoolean(CommonFSUtils.UNSAFE_STREAM_CAPABILITY_ENFORCE, false);
     Path testDir = htu.getDataTestDir();
     fs = testDir.getFileSystem(conf);
     CommonFSUtils.setWALRootDir(conf, testDir);