You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@netbeans.apache.org by "Thomas Zimmermann (Jira)" <ji...@apache.org> on 2019/10/26 21:50:00 UTC
[jira] [Comment Edited] (NETBEANS-1396) Maven: Downloaded javadoc /
sources not attached to artifact with classifier
[ https://issues.apache.org/jira/browse/NETBEANS-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955497#comment-16955497 ]
Thomas Zimmermann edited comment on NETBEANS-1396 at 10/26/19 9:49 PM:
-----------------------------------------------------------------------
[~jgneff]
You are correct, the Javadoc isn't used because of a silly bug, see my PR with the fix [here|https://github.com/apache/netbeans/pull/1548/commits/b02c59fda5f962f071e77f920c2115b7940f4a4d#diff-f1b8dd6458da9fb8ddb0ba46d941d35dL266]. NetBeans is looking for `javafx-graphics-13-.jar-javadoc.jar` instead of `javafx-graphics-13-linux-javadoc.jar`. Even if that was fixed though, OpenJFX uses the new HTML output format from javadoc 9+ and NetBeans doesn't parse that correctly yet. And even if it parsed that correctly, OpenJFX stores the HTML pages in the javadoc jars prefixed by module name, so NetBeans wouldn't find them. All this is fixed in my PR. I don't want to rush the nice NetBeans developers though, it seems like they want to get 11.2 out and this isn't that critical IMO.
was (Author: zimmi):
[~jgneff]
You are correct, the Javadoc isn't used because of a silly bug, see my PR with the fix [here|https://github.com/apache/netbeans/pull/1548/commits/ff152ec70ab53081d0470c97ffb065f880d733fb#diff-f1b8dd6458da9fb8ddb0ba46d941d35dR266]. NetBeans is looking for `javafx-graphics-13-.jar-javadoc.jar` instead of `javafx-graphics-13-linux-javadoc.jar`. Even if that was fixed though, OpenJFX uses the new HTML output format from javadoc 9+ and NetBeans doesn't parse that correctly yet. And even if it parsed that correctly, OpenJFX stores the HTML pages in the javadoc jars prefixed by module name, so NetBeans wouldn't find them. All this is fixed in my PR. I don't want to rush the nice NetBeans developers though, it seems like they want to get 11.2 out and this isn't that critical IMO.
> Maven: Downloaded javadoc / sources not attached to artifact with classifier
> ----------------------------------------------------------------------------
>
> Key: NETBEANS-1396
> URL: https://issues.apache.org/jira/browse/NETBEANS-1396
> Project: NetBeans
> Issue Type: Bug
> Reporter: Thomas Zimmermann
> Priority: Major
> Labels: pull-request-available
> Attachments: javafx11-javadoc-sources-download.zip
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The Maven artifacts org.openjfx:javafx-controls and friends use a jar with classifier for each operating system for the actual classes, javafx-controls is only an empty shell. If I understand correctly, sources / javadoc are attached in maven by having additional artifacts with the classifiers "sources" and "javadoc". Both are available for javafx-controls etc., but NetBeans doesn't use them for javafx-controls (linux) (the platform specific version with the actual classes). I think that's a bug, NetBeans should use the sources and javadoc artifacts for all artifacts of the same groupId + artifactId.
> Steps to reproduce:
> # Download attached maven project
> # Right click Dependencies -> Download Javadoc + Download Sources
> # Open App.java, see that no source / docs are attached for javafx.application.Application
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@netbeans.apache.org
For additional commands, e-mail: commits-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists