You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by dh...@apache.org on 2017/02/24 23:16:24 UTC
[1/2] beam git commit: Ignore undeclared outputs in the java fn
harness
Repository: beam
Updated Branches:
refs/heads/master b1fd55f0c -> d79fb3e06
Ignore undeclared outputs in the java fn harness
Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/fa13c7b9
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/fa13c7b9
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/fa13c7b9
Branch: refs/heads/master
Commit: fa13c7b9362c65d8d61e914d3822dea025400d5b
Parents: b1fd55f
Author: Vikas Kedigehalli <vi...@google.com>
Authored: Fri Feb 24 11:04:55 2017 -0800
Committer: Dan Halperin <dh...@google.com>
Committed: Fri Feb 24 15:16:13 2017 -0800
----------------------------------------------------------------------
.../apache/beam/fn/harness/control/ProcessBundleHandler.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/beam/blob/fa13c7b9/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java
----------------------------------------------------------------------
diff --git a/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java b/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java
index 1f82085..72cba79 100644
--- a/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java
+++ b/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java
@@ -293,9 +293,9 @@ public class ProcessBundleHandler {
Collection<ThrowingConsumer<WindowedValue<?>>> consumers =
tupleTagToOutput.get(tag);
if (consumers == null) {
- // TODO: Should we handle undeclared outputs, if so how?
- throw new UnsupportedOperationException(String.format(
- "Unable to output %s on unknown output %s", output, tag));
+ /* This is a normal case, e.g., if a DoFn has output but that output is not
+ * consumed. Drop the output. */
+ return;
}
for (ThrowingConsumer<WindowedValue<?>> consumer : consumers) {
consumer.accept(output);
[2/2] beam git commit: This closes #2100
Posted by dh...@apache.org.
This closes #2100
Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/d79fb3e0
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/d79fb3e0
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/d79fb3e0
Branch: refs/heads/master
Commit: d79fb3e06ddc8ff7d06645d0c4a2c685a90c250b
Parents: b1fd55f fa13c7b
Author: Dan Halperin <dh...@google.com>
Authored: Fri Feb 24 15:16:15 2017 -0800
Committer: Dan Halperin <dh...@google.com>
Committed: Fri Feb 24 15:16:15 2017 -0800
----------------------------------------------------------------------
.../apache/beam/fn/harness/control/ProcessBundleHandler.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------