You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2016/02/18 17:42:21 UTC

Review Request 43721: Metrics collector running out of file descriptors

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43721/
-----------------------------------------------------------

Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-15091
    https://issues.apache.org/jira/browse/AMBARI-15091


Repository: ambari


Description
-------

1200 node cluster:
[root@perf-a-2 ~]# lsof -p 4100 | wc -l
32928
Exception in collector logs:
2016-02-05 15:51:50,528 WARN org.mortbay.log: EXCEPTION
java.io.IOException: Too many open files
        at sun.nio.ch.ServerSocketChannelImpl.accept0(Native Method)
        at sun.nio.ch.ServerSocketChannelImpl.accept(ServerSocketChannelImpl.java:422)
        at sun.nio.ch.ServerSocketChannelImpl.accept(ServerSocketChannelImpl.java:250)
        at org.mortbay.jetty.nio.SelectChannelConnector$1.acceptChannel(SelectChannelConnector.java:75)
        at org.mortbay.io.nio.SelectorManager$SelectSet.doSelect(SelectorManager.java:695)
        at org.mortbay.io.nio.SelectorManager.doSelect(SelectorManager.java:193)
        at org.mortbay.jetty.nio.SelectChannelConnector.accept(SelectChannelConnector.java:124)
        at org.mortbay.jetty.AbstractConnector$Acceptor.run(AbstractConnector.java:708)
        at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)
The client side connections are also open and there are plenty of CLOSE_WAIT sockets.


Diffs
-----

  ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java 2854898 
  ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java 62a8cc3 
  ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/net/RestMetricsSender.java 0a9a513 
  ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryStoreTestUtils.java c41b8a7 
  ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryClientService.java 2fdedb2 
  ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestFileSystemApplicationHistoryStore.java bc16d36 
  ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestMemoryApplicationHistoryStore.java fc5c096 
  ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TestAHSWebServices.java e78dfcc 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 7c69ac9 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 7c578f2 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 14a28d3 

Diff: https://reviews.apache.org/r/43721/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 43721: Metrics collector running out of file descriptors

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43721/#review119739
-----------------------------------------------------------


Ship it!




Ship It!

- Sid Wagle


On Feb. 18, 2016, 4:42 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43721/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 4:42 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-15091
>     https://issues.apache.org/jira/browse/AMBARI-15091
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1200 node cluster:
> [root@perf-a-2 ~]# lsof -p 4100 | wc -l
> 32928
> Exception in collector logs:
> 2016-02-05 15:51:50,528 WARN org.mortbay.log: EXCEPTION
> java.io.IOException: Too many open files
>         at sun.nio.ch.ServerSocketChannelImpl.accept0(Native Method)
>         at sun.nio.ch.ServerSocketChannelImpl.accept(ServerSocketChannelImpl.java:422)
>         at sun.nio.ch.ServerSocketChannelImpl.accept(ServerSocketChannelImpl.java:250)
>         at org.mortbay.jetty.nio.SelectChannelConnector$1.acceptChannel(SelectChannelConnector.java:75)
>         at org.mortbay.io.nio.SelectorManager$SelectSet.doSelect(SelectorManager.java:695)
>         at org.mortbay.io.nio.SelectorManager.doSelect(SelectorManager.java:193)
>         at org.mortbay.jetty.nio.SelectChannelConnector.accept(SelectChannelConnector.java:124)
>         at org.mortbay.jetty.AbstractConnector$Acceptor.run(AbstractConnector.java:708)
>         at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)
> The client side connections are also open and there are plenty of CLOSE_WAIT sockets.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java 2854898 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java 62a8cc3 
>   ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/loadsimulator/net/RestMetricsSender.java 0a9a513 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryStoreTestUtils.java c41b8a7 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryClientService.java 2fdedb2 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestFileSystemApplicationHistoryStore.java bc16d36 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestMemoryApplicationHistoryStore.java fc5c096 
>   ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TestAHSWebServices.java e78dfcc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 7c69ac9 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 7c578f2 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 14a28d3 
> 
> Diff: https://reviews.apache.org/r/43721/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>