You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2025/05/22 06:56:58 UTC

[Bug 69697] New: Error in public HSLFPictureData getPictureData() of class HSLFPictureShape

https://bz.apache.org/bugzilla/show_bug.cgi?id=69697

            Bug ID: 69697
           Summary: Error in public HSLFPictureData getPictureData() of
                    class HSLFPictureShape
           Product: POI
           Version: 5.4.1-FINAL
          Hardware: PC
                OS: Mac OS X 10.1
            Status: NEW
          Severity: critical
          Priority: P2
         Component: HSLF
          Assignee: dev@poi.apache.org
          Reporter: parvathyskumar187@gmail.com
  Target Milestone: ---

Created attachment 40041
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=40041&action=edit
java file that can be used for testing

In the function getPictureData() of class HSLFPictureShape, these lines of code
                // Reference equals is safe because these BSE belong to the
same slideshow
                if (pd.bse == bse) {
                    return pd;
                }
            }
will not work since Reference equals wont be correct here. Instead the old way
of comparing offsets should be used here.

                if (pd.getOffset() ==  bse.getOffset()){
                    return pd;
                }

Attaching a sample .java file with a .ppt file whose picture wont be extracted
due to the error in this comparison.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 69697] Error in public HSLFPictureData getPictureData() of class HSLFPictureShape

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=69697

PJ Fanning <fa...@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 69697] Error in public HSLFPictureData getPictureData() of class HSLFPictureShape

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=69697

--- Comment #2 from PJ Fanning <fa...@yahoo.com> ---
I added
https://github.com/apache/poi/commit/c01228c331fce2743e1434ebdea31b895615b41d

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 69697] Error in public HSLFPictureData getPictureData() of class HSLFPictureShape

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=69697

PJ Fanning <fa...@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|Mac OS X 10.1               |All
           Hardware|PC                          |All
           Severity|critical                    |major

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: [Bug 69697] Error in public HSLFPictureData getPictureData() of class HSLFPictureShape

Posted by Kamal Chandrashekar <sa...@gmail.com>.
Put try t each step

On Thursday, May 22, 2025, <bu...@apache.org> wrote:

> https://bz.apache.org/bugzilla/show_bug.cgi?id=69697
>
> --- Comment #1 from parvathyskumar187@gmail.com ---
> Created attachment 40042
>   --> https://bz.apache.org/bugzilla/attachment.cgi?id=40042&action=edit
> ppt file that can be used for testing
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>

--

[Bug 69697] Error in public HSLFPictureData getPictureData() of class HSLFPictureShape

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=69697

--- Comment #1 from parvathyskumar187@gmail.com ---
Created attachment 40042
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=40042&action=edit
ppt file that can be used for testing

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org