You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2017/01/13 18:54:54 UTC
[kudu-CR] Don't build kudu test * if NO TESTS set
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5711
Change subject: Don't build kudu_test_* if NO_TESTS set
......................................................................
Don't build kudu_test_* if NO_TESTS set
Also rename NO_TESTS to NO_KUDU_TESTS.
Change-Id: I69344fc79cdda30456ab261838c5bc50bab1a420
---
M CMakeLists.txt
M README.adoc
M docs/support/scripts/make_site.sh
M src/kudu/twitter-demo/CMakeLists.txt
M src/kudu/util/CMakeLists.txt
5 files changed, 38 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/5711/1
--
To view, visit http://gerrit.cloudera.org:8080/5711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I69344fc79cdda30456ab261838c5bc50bab1a420
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
[kudu-CR] Don't build kudu test * if NO TESTS set
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5711
to look at the new patch set (#3).
Change subject: Don't build kudu_test_* if NO_TESTS set
......................................................................
Don't build kudu_test_* if NO_TESTS set
Change-Id: I69344fc79cdda30456ab261838c5bc50bab1a420
---
M src/kudu/security/CMakeLists.txt
M src/kudu/util/CMakeLists.txt
2 files changed, 44 insertions(+), 40 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/5711/3
--
To view, visit http://gerrit.cloudera.org:8080/5711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69344fc79cdda30456ab261838c5bc50bab1a420
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Don't build kudu test * if NO TESTS set
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: Don't build kudu_test_* if NO_TESTS set
......................................................................
Patch Set 2:
My reason is that adding set(NO_TESTS 1) in an Impala CMakefile.txts looks weird if it doesn't actually disable tests. (We don't want to build tests because... they get run by Kudu anyhow :)).
From Kudu's perspective you already have ADD_KUDU_TEST, so it seems consistent to say NO_KUDU_TESTS.
I don't feel strongly though - didn't realise there were many dependencies on that variable. Want me to change it back?
--
To view, visit http://gerrit.cloudera.org:8080/5711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69344fc79cdda30456ab261838c5bc50bab1a420
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Don't build kudu test * if NO TESTS set
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: Don't build kudu_test_* if NO_TESTS set
......................................................................
Don't build kudu_test_* if NO_TESTS set
Change-Id: I69344fc79cdda30456ab261838c5bc50bab1a420
Reviewed-on: http://gerrit.cloudera.org:8080/5711
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/security/CMakeLists.txt
M src/kudu/util/CMakeLists.txt
2 files changed, 44 insertions(+), 40 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I69344fc79cdda30456ab261838c5bc50bab1a420
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Don't build kudu test * if NO TESTS set
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Don't build kudu_test_* if NO_TESTS set
......................................................................
Patch Set 2:
> My reason is that adding set(NO_TESTS 1) in an Impala
> CMakefile.txts looks weird if it doesn't actually disable tests.
> (We don't want to build tests because... they get run by Kudu
> anyhow :)).
>
> From Kudu's perspective you already have ADD_KUDU_TEST, so it seems
> consistent to say NO_KUDU_TESTS.
>
> I don't feel strongly though - didn't realise there were many
> dependencies on that variable. Want me to change it back?
If you volunteer to make the changes I'm fine with it. I can point you in the right direction.
--
To view, visit http://gerrit.cloudera.org:8080/5711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69344fc79cdda30456ab261838c5bc50bab1a420
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Don't build kudu test * if NO TESTS set
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Don't build kudu_test_* if NO_TESTS set
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69344fc79cdda30456ab261838c5bc50bab1a420
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Don't build kudu test * if NO TESTS set
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Don't build kudu_test_* if NO_TESTS set
......................................................................
Patch Set 2:
The change makes sense, but the variable rename isn't free; we have Jenkins job configs and packaging code we'll need to update. What's the justification?
--
To view, visit http://gerrit.cloudera.org:8080/5711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69344fc79cdda30456ab261838c5bc50bab1a420
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Don't build kudu test * if NO TESTS set
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: Don't build kudu_test_* if NO_TESTS set
......................................................................
Patch Set 2:
> If you volunteer to make the changes I'm fine with it. I can point you in the right direction.
Some other time, perhaps. Reverted that change for now.
--
To view, visit http://gerrit.cloudera.org:8080/5711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69344fc79cdda30456ab261838c5bc50bab1a420
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Don't build kudu test * if NO TESTS set
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5711
to look at the new patch set (#2).
Change subject: Don't build kudu_test_* if NO_TESTS set
......................................................................
Don't build kudu_test_* if NO_TESTS set
Also rename NO_TESTS to NO_KUDU_TESTS.
Change-Id: I69344fc79cdda30456ab261838c5bc50bab1a420
---
M CMakeLists.txt
M README.adoc
M docs/support/scripts/make_site.sh
M src/kudu/twitter-demo/CMakeLists.txt
M src/kudu/util/CMakeLists.txt
5 files changed, 38 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/5711/2
--
To view, visit http://gerrit.cloudera.org:8080/5711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69344fc79cdda30456ab261838c5bc50bab1a420
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins