You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2019/12/30 05:53:56 UTC

[camel] branch master updated: Synchronized methods of sub-classes which override synchronized methods (as suggested by lgtm.com). (#3452)

This is an automated email from the ASF dual-hosted git repository.

davsclaus pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/master by this push:
     new 64bc785  Synchronized methods of sub-classes which override synchronized methods (as suggested by lgtm.com). (#3452)
64bc785 is described below

commit 64bc7857d721ce08f00b0bf0ea18f45ed2c084a1
Author: Pascal Schumacher <pa...@gmx.net>
AuthorDate: Mon Dec 30 06:53:47 2019 +0100

    Synchronized methods of sub-classes which override synchronized methods (as suggested by lgtm.com). (#3452)
---
 .../org/apache/camel/component/jmx/JMXConsumerNotificationFilter.java   | 2 +-
 .../camel/component/netty/http/NettyChannelBufferStreamCache.java       | 2 +-
 .../org/apache/camel/component/splunk/support/SubmitDataWriter.java     | 2 +-
 .../org/apache/camel/converter/stream/ByteArrayInputStreamCache.java    | 2 +-
 .../main/java/org/apache/camel/converter/stream/CachedOutputStream.java | 2 +-
 .../java/org/apache/camel/converter/stream/FileInputStreamCache.java    | 2 +-
 core/camel-util/src/main/java/org/apache/camel/util/IOHelper.java       | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/components/camel-jmx/src/main/java/org/apache/camel/component/jmx/JMXConsumerNotificationFilter.java b/components/camel-jmx/src/main/java/org/apache/camel/component/jmx/JMXConsumerNotificationFilter.java
index 00e1a1d..31d75c3 100644
--- a/components/camel-jmx/src/main/java/org/apache/camel/component/jmx/JMXConsumerNotificationFilter.java
+++ b/components/camel-jmx/src/main/java/org/apache/camel/component/jmx/JMXConsumerNotificationFilter.java
@@ -36,7 +36,7 @@ public class JMXConsumerNotificationFilter extends AttributeChangeNotificationFi
     }
 
     @Override
-    public boolean isNotificationEnabled(Notification notification) {
+    public synchronized boolean isNotificationEnabled(Notification notification) {
         boolean enabled = super.isNotificationEnabled(notification);
         if (!enabled) {
             return false;
diff --git a/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/NettyChannelBufferStreamCache.java b/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/NettyChannelBufferStreamCache.java
index d034a31..1a74f61 100644
--- a/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/NettyChannelBufferStreamCache.java
+++ b/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/NettyChannelBufferStreamCache.java
@@ -72,7 +72,7 @@ public final class NettyChannelBufferStreamCache extends InputStream implements
     }
 
     @Override
-    public void reset() {
+    public synchronized void reset() {
         buffer.resetReaderIndex();
     }
 
diff --git a/components/camel-splunk/src/main/java/org/apache/camel/component/splunk/support/SubmitDataWriter.java b/components/camel-splunk/src/main/java/org/apache/camel/component/splunk/support/SubmitDataWriter.java
index 05cc336..f9587b0 100644
--- a/components/camel-splunk/src/main/java/org/apache/camel/component/splunk/support/SubmitDataWriter.java
+++ b/components/camel-splunk/src/main/java/org/apache/camel/component/splunk/support/SubmitDataWriter.java
@@ -33,7 +33,7 @@ public class SubmitDataWriter extends SplunkDataWriter {
     }
 
     @Override
-    protected void doWrite(String event) throws IOException {
+    protected synchronized void doWrite(String event) throws IOException {
         Index index = getIndex();
         if (index != null) {
             index.submit(args, event);
diff --git a/core/camel-support/src/main/java/org/apache/camel/converter/stream/ByteArrayInputStreamCache.java b/core/camel-support/src/main/java/org/apache/camel/converter/stream/ByteArrayInputStreamCache.java
index 22fbc16..664793c 100644
--- a/core/camel-support/src/main/java/org/apache/camel/converter/stream/ByteArrayInputStreamCache.java
+++ b/core/camel-support/src/main/java/org/apache/camel/converter/stream/ByteArrayInputStreamCache.java
@@ -40,7 +40,7 @@ public class ByteArrayInputStreamCache extends FilterInputStream implements Stre
     }
 
     @Override
-    public void reset() {
+    public synchronized void reset() {
         try {
             super.reset();
         } catch (IOException e) {
diff --git a/core/camel-support/src/main/java/org/apache/camel/converter/stream/CachedOutputStream.java b/core/camel-support/src/main/java/org/apache/camel/converter/stream/CachedOutputStream.java
index b71885b..af7c738 100644
--- a/core/camel-support/src/main/java/org/apache/camel/converter/stream/CachedOutputStream.java
+++ b/core/camel-support/src/main/java/org/apache/camel/converter/stream/CachedOutputStream.java
@@ -185,7 +185,7 @@ public class CachedOutputStream extends OutputStream {
         }
         
         @Override
-        public void reset() throws IOException {
+        public synchronized void reset() throws IOException {
             inputStream.reset();
         }
         
diff --git a/core/camel-support/src/main/java/org/apache/camel/converter/stream/FileInputStreamCache.java b/core/camel-support/src/main/java/org/apache/camel/converter/stream/FileInputStreamCache.java
index 99b46db..f5c2567 100644
--- a/core/camel-support/src/main/java/org/apache/camel/converter/stream/FileInputStreamCache.java
+++ b/core/camel-support/src/main/java/org/apache/camel/converter/stream/FileInputStreamCache.java
@@ -78,7 +78,7 @@ public final class FileInputStreamCache extends InputStream implements StreamCac
     }
 
     @Override
-    public void reset() {
+    public synchronized void reset() {
         // reset by closing and creating a new stream based on the file
         close();
         // reset by creating a new stream based on the file
diff --git a/core/camel-util/src/main/java/org/apache/camel/util/IOHelper.java b/core/camel-util/src/main/java/org/apache/camel/util/IOHelper.java
index b5e8d2a..c5fb6c9 100644
--- a/core/camel-util/src/main/java/org/apache/camel/util/IOHelper.java
+++ b/core/camel-util/src/main/java/org/apache/camel/util/IOHelper.java
@@ -591,7 +591,7 @@ public final class IOHelper {
         }
 
         @Override
-        public void reset() throws IOException {
+        public synchronized void reset() throws IOException {
             reader.reset();
         }