[GitHub] [iceberg] pvary commented on a change in pull request #3162: Hive: Set catalog type to null if catalog-impl is set

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #3162:
URL: https://github.com/apache/iceberg/pull/3162#discussion_r713142119



##########
File path: mr/src/main/java/org/apache/iceberg/mr/Catalogs.java
##########
@@ -270,22 +287,41 @@ public static boolean hiveCatalog(Configuration conf, Properties props) {
    */
   private static String getCatalogType(Configuration conf, String catalogName) {
     if (catalogName != null) {
-      String catalogType = conf.get(InputFormatConfig.catalogPropertyConfigKey(
-          catalogName, CatalogUtil.ICEBERG_CATALOG_TYPE));

Review comment:
       Do we need this refactor? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org